This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 109431 - I18N - bpel project encoding property is not present
Summary: I18N - bpel project encoding property is not present
Status: VERIFIED FIXED
Alias: None
Product: soa
Classification: Unclassified
Component: BPEL Project (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Vitaly Bychkov
URL:
Keywords: I18N
Depends on: 109429
Blocks: 100312
  Show dependency tree
 
Reported: 2007-07-11 21:59 UTC by Jun Qian
Modified: 2007-08-15 17:53 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jun Qian 2007-07-11 21:59:38 UTC
See umbrella ticket #100312
Comment 1 Jun Qian 2007-07-11 22:01:37 UTC
This ticket semi-depends on #109429
Comment 2 Vladimir Yaroslavskiy 2007-07-17 14:27:11 UTC
Vitaly will fix it with xslt project.
Comment 3 Ken Frank 2007-07-24 19:53:58 UTC
what about encoding handling of .bpel files -part of the encoding work is to make sure about
encoding handling for file types as well; for example in progress or done is file encoding handling
for jsp/html/xml/properties files.

these would be separate issues if needed.

I don't know if its needed for .bpel  since when click on src tab, its in xml format -- so is it really an 
xml file ?

what about .wsdl, are they really an xml file ?

and the sql project .sql file ?  I think it is a text file - I don't know if the running of it uses
the same api or functionality of other db queries created in nb - nor do I know how in general
the db query is handled - I'll ask db team.


ken.frank@sun.com


Comment 4 Vitaly Bychkov 2007-07-25 15:13:14 UTC
Fixed.
Comment 5 Vitaly Bychkov 2007-07-25 15:31:25 UTC
Ken If I'm right understand you mean e.g. next scenario:
if project encoding properties is UTF-8, but xml file inside these project has 
encoding="windows-1251" then this xml file should be stored with encoding "windows-1251"

If so then Ken please fill issues against encoding support for different type of files.
It would be nice to have one umbrella issue for it.

Comment 6 Ken Frank 2007-07-25 16:24:39 UTC
Ken If I'm right understand you mean e.g. next scenario:
if project encoding properties is UTF-8, but xml file inside these project has 
encoding="windows-1251" then this xml file should be stored with encoding "windows-1251"

--> I'm not sure of the answer since the xml impelementation of the feq has not been completed -

see issues 97872 and 107911 - from some info from developer on xml files already
created:

if file encoding tag exists, it will be used instead of project encoding - file
enc has higher priority

what if no enc tag in the file or user removes it ?

For xml files the encoding can be defined according specification also
in the first two bytes of the file stream. You are not able to see these
bytes in the editor, but the encoding is defined in the the file itself.
Of course the encoding can be also defined in the <?xml encoding="xxx"?>
processing instruction. So there two ways how the encoding in xml files
can be stored.  If the xml file doesn't contain any encoding than the
project encoding should be used. But i'm not 100% sure, because I think
that the W3C xml specification defines and default encoding as well.


question - if a bpel or wsdl is just another xml file, then perhaps no additional
issue is needed ?  but if your modules need to change code to work with that
new behavior, then it might need issues ?

one thing is we dont know if/when the 2 xml issues mentioned will be fixed.


also, if you need sep issues, please list on what file types they should be on,
ie bpel, wsdl, sql, etc .

ken.frank@sun.com
Comment 7 Ken Frank 2007-07-31 16:56:09 UTC
am using build 0727 - is this fix in that one ? I am not seeing the ok behavior for this or for the xslt
project - instead it is using the encoding of the locale the user is in as default; whether its the first
project created in the session or being created after some other non soa project has changed encoding
to something other than utf-8, which is the default.

as to the encoding of xml files vs project encoding - the xml feq issues are not done yet, 
97872 and 107911; so things could change in your projects use of it when that happens - can you

talk with owners of those bugs to see if your team needs to do anything about it once they are fixed 
(and to see if sep issues are needed in enterprise) 

ken.frank@sun.com
Comment 8 Ken Frank 2007-08-05 19:36:05 UTC
reopening - the global project encoding is not being used when create the project - the encoding of the
locale user is in is being used; and when changing the project encoding of this project, it does not
cause next created project like j2se project, to use that encoding.

ken.frank@sun.com
Comment 9 Vitaly Bychkov 2007-08-08 05:39:05 UTC
Fixed in trunk:

/cvs/enterprise/bpel/project/src/org/netbeans/modules/bpel/project/BpelproProject.java,v  <--  BpelproProject.java
new revision: 1.18; previous revision: 1.17
/cvs/enterprise/bpel/project/src/org/netbeans/modules/bpel/project/BpelproProjectGenerator.java,v  <-- 
BpelproProjectGenerator.java
new revision: 1.12; previous revision: 1.11
Comment 10 kaa 2007-08-15 17:53:16 UTC
verified: build 0812, Bpel Module has project encoding property in project properties.