This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 107254 - Mouse clicks and DnD should work in empty diff gutter
Summary: Mouse clicks and DnD should work in empty diff gutter
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jan Pokorsky
URL:
Keywords: UI
Depends on: 112948 113008 113182
Blocks: 88714
  Show dependency tree
 
Reported: 2007-06-19 15:47 UTC by jrojcek
Modified: 2007-11-05 13:42 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jrojcek 2007-06-19 15:47:53 UTC 
It should be possible to select a block of text when dragging mouse over empty diff gutter. Also clicking into the empty diff gutter should place the cursor to 
the beginning of line. That's how it works in folding gutter.
Comment 1 Vitezslav Stejskal 2007-06-25 17:02:58 UTC 
Clicking an empty space in the gutter toggles a breakpoint on/off on that line. What should happen to this functionality?
Comment 2 jrojcek 2007-06-25 17:51:22 UTC 
Note that this issue is about the *diff* gutter. Maybe you use a different term for it. My point is that the behavior regarding clicking and DnD should be the 
same as in the empty "code folding" gutter.
Comment 3 jrojcek 2007-08-03 16:24:22 UTC 
I played with the editor today and it seems like the diff gutter and code folding gutter switched their position. Now the diff gutter is right next to the source 
code area. If the change  was intentional, then this issue should be fixed for 6.0. It's actually a regression over behavior in 5.5.

Currently in trunk build the user has to click with the mouse very carefully in order to put the keyboard cursor to the beginning of source code line. We fixed 
that for code folding gutter in the past and now the wrong behavior is back. The same should work for DnD. If the user wants to select block of code, 
currently she has to click very precisely to select it right from the beginning of the line. This is sort of regression and quite bad behavior so rising priority to  
P2.

BTW, I think that the diff gutter should be hidden automatically if the source file isn't versioned. And we should consider hiding it also if the file is versioned 
and there's no actual change to show (I'm not exactly sure about the jumping behavior, would have to see it in action).
Comment 4 Miloslav Metelka 2007-08-13 09:40:35 UTC 
OK I would like to arrange it so that individual panels do not need duplicate the code for making a line-based editor
selection. I hope that it could possibly work by making a parent panel supporting selection making and redispatching the
mouse events to parent panel from the individual panels.
Comment 5 Jan Pokorsky 2007-08-15 15:24:46 UTC 
It should work for all left side bars now. Fixed in

/cvs/editor/src/org/netbeans/modules/editor/NbEditorUI.java,v  <--  NbEditorUI.java
new revision: 1.70; previous revision: 1.69
/cvs/editor/libsrc/org/netbeans/editor/CodeFoldingSideBar.java,v  <--  CodeFoldingSideBar.java
new revision: 1.33; previous revision: 1.32