This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
See the "Realistic proposal" at http://ui.netbeans.org/docs/ui/DDBandConfig/index.html#5 Since we lost the "Attach Debugger" icon in the toolbar (issue #100899), this is meant as a replacement for now.
Created attachment 43638 [details] The prpposed solution in MainProjectAction, which allows to register Attach Debugger action.
Passing to API review, I have two possibilities how to do this: 1) apply the attached patch, that allows to register actions into "Actions/MainProjectAction/<command name>/" folder in default FS and MainProjectAction creates drop-down menu from that. Debuggercore will register "Attach Debugger..." action. 2) Move "Debug Main Project" action into debuggercore UI module. We could use MainProjectSensitiveActions.mainProjectCommandAction() and wrap it into our action, that would implement Presenter.Toolbar. This will allow us to fix issue #103224. Moving to API review to decide which option is better. Is there any reason why "Debug Main Project" was put into projects/projectui module along with the rest of main-project-sensitive actions and not into debuggercore UI?
Probably #2 is OK, assuming no one with a non-debuggercore-based project debugging facility wishes to debug their projects. (Or even then it may be OK, so long as your impl continues to use ActionProvider on the "debug" command, and just adds some extra stuff designed to work with debuggercore.)
Thanks for comments, I'll implement the second approach - move the debugger-related actions from projects/projectui into debuggercore. The actions still refer to MainProjectAction or FileCommandAction, thus the implementation did not change.
Created attachment 43727 [details] The changes in debuggercore and projects/projectui modules
Created attachment 43728 [details] DebugMainProjectAction class, that adds the drop-down.
I'm going to commit the move of debugger actions from projects/projectui to debuggercore on Friday 15 evening CET. No APIs are modified, this is just an architectural change.
Fixed in trunk: RCS file: /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugProject.png,v done Checking in debuggercore/src/org/netbeans/modules/debugger/resources/debugProject.png; /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugProject.png,v <-- debugProject.png initial revision: 1.1 done RCS file: /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugProject24.png,v done Checking in debuggercore/src/org/netbeans/modules/debugger/resources/debugProject24.png; /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugProject24.png,v <-- debugProject24.png initial revision: 1.1 done RCS file: /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugSingle.png,v done Checking in debuggercore/src/org/netbeans/modules/debugger/resources/debugSingle.png; /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugSingle.png,v <-- debugSingle.png initial revision: 1.1 done RCS file: /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugSingle24.png,v done Checking in debuggercore/src/org/netbeans/modules/debugger/resources/debugSingle24.png; /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugSingle24.png,v <-- debugSingle24.png initial revision: 1.1 done RCS file: /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugTestSingle.png,v done Checking in debuggercore/src/org/netbeans/modules/debugger/resources/debugTestSingle.png; /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugTestSingle.png,v <-- debugTestSingle.png initial revision: 1.1 done RCS file: /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugTestSingle24.png,v done Checking in debuggercore/src/org/netbeans/modules/debugger/resources/debugTestSingle24.png; /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/debugTestSingle24.png,v <-- debugTestSingle24.png initial revision: 1.1 done Checking in debuggercore/src/org/netbeans/modules/debugger/resources/mf-layer.xml; /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/resources/mf-layer.xml,v <-- mf-layer.xml new revision: 1.80; previous revision: 1.79 done Checking in debuggercore/src/org/netbeans/modules/debugger/ui/actions/Bundle.properties; /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/ui/actions/Bundle.properties,v <-- Bundle.properties new revision: 1.15; previous revision: 1.14 done RCS file: /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/ui/actions/DebugMainProjectAction.java,v done Checking in debuggercore/src/org/netbeans/modules/debugger/ui/actions/DebugMainProjectAction.java; /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/ui/actions/DebugMainProjectAction.java,v <-- DebugMainProjectAction.java initial revision: 1.1 done Checking in debuggercore/src/org/netbeans/modules/debugger/ui/actions/DebuggerAction.java; /shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/ui/actions/DebuggerAction.java,v <-- DebuggerAction.java new revision: 1.17; previous revision: 1.16 done Checking in debuggercore/nbproject/project.xml; /shared/data/ccvs/repository/debuggercore/nbproject/project.xml,v <-- project.xml new revision: 1.14; previous revision: 1.13 done Checking in projects/projectui/src/org/netbeans/modules/project/ui/actions/Actions.java; /shared/data/ccvs/repository/projects/projectui/src/org/netbeans/modules/project/ui/actions/Actions.java,v <-- Actions.java new revision: 1.33; previous revision: 1.32 done Checking in projects/projectui/src/org/netbeans/modules/project/ui/actions/Bundle.properties; /shared/data/ccvs/repository/projects/projectui/src/org/netbeans/modules/project/ui/actions/Bundle.properties,v <-- Bundle.properties new revision: 1.37; previous revision: 1.36 done Removing projects/projectui/src/org/netbeans/modules/project/ui/resources/debugProject.gif; /shared/data/ccvs/repository/projects/projectui/src/org/netbeans/modules/project/ui/resources/debugProject.gif,v <-- debugProject.gif new revision: delete; previous revision: 1.7 done Removing projects/projectui/src/org/netbeans/modules/project/ui/resources/debugProject.png; /shared/data/ccvs/repository/projects/projectui/src/org/netbeans/modules/project/ui/resources/debugProject.png,v <-- debugProject.png new revision: delete; previous revision: 1.2 done Removing projects/projectui/src/org/netbeans/modules/project/ui/resources/debugProject24.png; /shared/data/ccvs/repository/projects/projectui/src/org/netbeans/modules/project/ui/resources/debugProject24.png,v <-- debugProject24.png new revision: delete; previous revision: 1.2 done Removing projects/projectui/src/org/netbeans/modules/project/ui/resources/debugSingle.png; /shared/data/ccvs/repository/projects/projectui/src/org/netbeans/modules/project/ui/resources/debugSingle.png,v <-- debugSingle.png new revision: delete; previous revision: 1.1 done Removing projects/projectui/src/org/netbeans/modules/project/ui/resources/debugSingle24.png; /shared/data/ccvs/repository/projects/projectui/src/org/netbeans/modules/project/ui/resources/debugSingle24.png,v <-- debugSingle24.png new revision: delete; previous revision: 1.1 done Removing projects/projectui/src/org/netbeans/modules/project/ui/resources/debugTestSingle.png; /shared/data/ccvs/repository/projects/projectui/src/org/netbeans/modules/project/ui/resources/debugTestSingle.png,v <-- debugTestSingle.png new revision: delete; previous revision: 1.1 done Removing projects/projectui/src/org/netbeans/modules/project/ui/resources/debugTestSingle24.png; /shared/data/ccvs/repository/projects/projectui/src/org/netbeans/modules/project/ui/resources/debugTestSingle24.png,v <-- debugTestSingle24.png new revision: delete; previous revision: 1.1 done Checking in projects/projectui/src/org/netbeans/modules/project/ui/resources/layer.xml; /shared/data/ccvs/repository/projects/projectui/src/org/netbeans/modules/project/ui/resources/layer.xml,v <-- layer.xml new revision: 1.84; previous revision: 1.83 done Checking in debuggerjpda/ui/src/org/netbeans/modules/debugger/jpda/resources/mf-layer.xml; /shared/data/ccvs/repository/debuggerjpda/ui/src/org/netbeans/modules/debugger/jpda/resources/mf-layer.xml,v <-- mf-layer.xml new revision: 1.41; previous revision: 1.40 done Checking in ide/bluej-suite/bluej-welcome/src/org/netbeans/bluej/welcome/layer.xml; /shared/data/ccvs/repository/ide/bluej-suite/bluej-welcome/src/org/netbeans/bluej/welcome/layer.xml,v <-- layer.xml new revision: 1.5; previous revision: 1.4 done Checking in ide/defaults/src/org/netbeans/modules/defaults/mf-layer.xml; /shared/data/ccvs/repository/ide/defaults/src/org/netbeans/modules/defaults/mf-layer.xml,v <-- mf-layer.xml new revision: 1.36; previous revision: 1.35 done Checking in editor/options/src/org/netbeans/modules/options/editor/mf-layer.xml; /shared/data/ccvs/repository/editor/options/src/org/netbeans/modules/options/editor/mf-layer.xml,v <-- mf-layer.xml new revision: 1.37; previous revision: 1.36 done Checking in enterprise/dataintegrator/eTLEditor/src/org/netbeans/modules/etl/layer.xml; /shared/data/ccvs/repository/enterprise/dataintegrator/eTLEditor/src/org/netbeans/modules/etl/layer.xml,v <-- layer.xml new revision: 1.3; previous revision: 1.2 done Checking in scripting/ruby/projects/src/org/netbeans/modules/ruby/rubyproject/ui/resources/layer.xml; /shared/data/ccvs/repository/scripting/ruby/projects/src/org/netbeans/modules/ruby/rubyproject/ui/resources/layer.xml,v <-- layer.xml new revision: 1.14; previous revision: 1.13 done Checking in jellytools/builds/jelly2-nb.jar; /shared/data/ccvs/repository/jellytools/builds/jelly2-nb.jar,v <-- jelly2-nb.jar new revision: 1.138; previous revision: 1.137 done Checking in jellytools/src/org/netbeans/jellytools/modules/debugger/actions/DebugAction.java; /shared/data/ccvs/repository/jellytools/src/org/netbeans/jellytools/modules/debugger/actions/DebugAction.java,v <-- DebugAction.java new revision: 1.5; previous revision: 1.4 done
Verified ... and Closing all issues resolved into NetBeans 6.7 and earlier.