This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 106356 - Fix Imports always display dialog which I must to close manually
Summary: Fix Imports always display dialog which I must to close manually
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Source (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords: USABILITY
Depends on:
Blocks:
 
Reported: 2007-06-12 07:56 UTC by Vladimir Voskresensky
Modified: 2007-07-03 12:22 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Voskresensky 2007-06-12 07:56:27 UTC
Fix Imports always display dialog which I must to close manually and it is quite
annoying when everything was resolved without alternatives or no new imports
were needed.
Comment 1 Vladimir Voskresensky 2007-06-12 07:58:13 UTC
In fact I'd like to see it as P2 (to be fixed in 6.0 :-)), because very annoying
the press odd "Enter" per fix import action
Comment 2 Stanislav Aubrecht 2007-06-19 09:32:19 UTC
jano, what do you think?
Comment 3 Petr Hrebejk 2007-06-21 16:02:53 UTC
Not a P2. Very likely wontfix
Comment 4 ngbrito 2007-06-24 00:44:15 UTC
I also find it annoying. Specially if you have several imports being added at the same time because you will have to
check every one to see if there is really one which appears in more than 1 package.
Anyway, if it is not fixed then the message "The following class names were found in more than one package..." no longer
makes any sense and should be changed.
Comment 5 Stanislav Aubrecht 2007-06-26 14:39:20 UTC
i think it's easy to fix this issue but i'd like to get a comment from hie team first.
Comment 6 Stanislav Aubrecht 2007-07-02 14:40:17 UTC
jano, still waiting for your feedback...
Comment 7 jrojcek 2007-07-03 11:07:53 UTC
I think the "Fix Imports" action should *not* show the dialog in the following situations:

- there's no imports to fix (everything is okay)
- all imports to add are resolved (no import is ambiguous)

If we want to suppress the dialog, it needs to:

- always remove unused import (which I think is what users always want)
- provide a basic notification in the status line that the action completed successfully or there's nothing to fix

Comment 8 Vladimir Voskresensky 2007-07-03 11:20:52 UTC
I would say, that current unnecessary displaying of dialog is quite annoying and imho it's usability regression
comparing with 5.5 => may be there is a reason to upgrade to P2?
Comment 9 Stanislav Aubrecht 2007-07-03 12:22:34 UTC
fixed as jano suggested

/cvs/java/editor/src/org/netbeans/modules/java/editor/imports/JavaFixAllImports.java,v  <--  JavaFixAllImports.java
new revision: 1.13; previous revision: 1.12
done
Checking in Bundle.properties;
/cvs/java/editor/src/org/netbeans/modules/java/editor/imports/Bundle.properties,v  <--  Bundle.properties
new revision: 1.5; previous revision: 1.4