This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 105749 - [REFACTORING] Apply rename on comments checkbox does not have an effect
Summary: [REFACTORING] Apply rename on comments checkbox does not have an effect
Status: VERIFIED FIXED
Alias: None
Product: ruby
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Torbjorn Norbye
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-05 15:31 UTC by Tomas Danek
Modified: 2007-10-23 16:05 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Danek 2007-06-05 15:31:01 UTC
Product Version: NetBeans IDE Dev (Build 200706050000) Java: 1.6.0_01; Java
HotSpot(TM) Client VM 1.6.0_01-b06 System: Linux version 2.6.20-15-generic
running on i386; UTF-8; en_US (nb)
-------------------------------------
- have a code:

class A
  def A.a
  end
end

#A.a

- invoke rename on method "a"
- check Apply rename on comments
- preview and do refactoring ->  "#A.a" remained unchanged
Comment 1 _ gtzabari 2007-06-07 03:02:27 UTC
Is this a duplicate of issue 88220?
Comment 2 Tomas Danek 2007-06-07 14:37:25 UTC
Yes, it's about the same. However, i'm not sure, if this should be fixed only 
in java/refactoring, or both java/refactoring and ruby/refactoring, so leaving
this opened for now..
Comment 3 Torbjorn Norbye 2007-06-11 17:41:51 UTC
This is now implemented (for both rename and find usages).

IDE:-------------------------------------------------
IDE: [6/11/07 9:34 AM] Committing started
Checking in refactoring/src/org/netbeans/modules/refactoring/ruby/RetoucheUtils.java;
/cvs/scripting/ruby/refactoring/src/org/netbeans/modules/refactoring/ruby/RetoucheUtils.java,v  <--  
RetoucheUtils.java
new revision: 1.4; previous revision: 1.3
done
Checking in refactoring/src/org/netbeans/modules/refactoring/ruby/RubyElementCtx.java;
/cvs/scripting/ruby/refactoring/src/org/netbeans/modules/refactoring/ruby/RubyElementCtx.java,v  
<--  RubyElementCtx.java
new revision: 1.7; previous revision: 1.6
done
Checking in refactoring/src/org/netbeans/modules/refactoring/ruby/WhereUsedElement.java;
/cvs/scripting/ruby/refactoring/src/org/netbeans/modules/refactoring/ruby/WhereUsedElement.java,v  
<--  WhereUsedElement.java
new revision: 1.4; previous revision: 1.3
done
Checking in editing/src/org/netbeans/modules/ruby/AstUtilities.java;
/cvs/scripting/ruby/editing/src/org/netbeans/modules/ruby/AstUtilities.java,v  <--  AstUtilities.java
new revision: 1.28; previous revision: 1.27
done
Checking in refactoring/src/org/netbeans/modules/refactoring/ruby/plugins/
RenameRefactoringPlugin.java;
/cvs/scripting/ruby/refactoring/src/org/netbeans/modules/refactoring/ruby/plugins/
RenameRefactoringPlugin.java,v  <--  RenameRefactoringPlugin.java
new revision: 1.7; previous revision: 1.6
done
Checking in refactoring/src/org/netbeans/modules/refactoring/ruby/plugins/
RubyWhereUsedQueryPlugin.java;
/cvs/scripting/ruby/refactoring/src/org/netbeans/modules/refactoring/ruby/plugins/
RubyWhereUsedQueryPlugin.java,v  <--  RubyWhereUsedQueryPlugin.java
new revision: 1.4; previous revision: 1.3
done
Checking in kit/manifest.mf;
/cvs/scripting/ruby/kit/manifest.mf,v  <--  manifest.mf
new revision: 1.78; previous revision: 1.77
done
Checking in editing/manifest.mf;
/cvs/scripting/ruby/editing/manifest.mf,v  <--  manifest.mf
new revision: 1.64; previous revision: 1.63
done
Checking in refactoring/manifest.mf;
/cvs/scripting/ruby/refactoring/manifest.mf,v  <--  manifest.mf
new revision: 1.5; previous revision: 1.4
done
Checking in refactoring/src/org/netbeans/modules/refactoring/ruby/ui/tree/ElementGrip.java;
/cvs/scripting/ruby/refactoring/src/org/netbeans/modules/refactoring/ruby/ui/tree/
ElementGrip.java,v  <--  ElementGrip.java
new revision: 1.2; previous revision: 1.1
done
Checking in refactoring/src/org/netbeans/modules/refactoring/ruby/ui/tree/ElementGripFactory.java;
/cvs/scripting/ruby/refactoring/src/org/netbeans/modules/refactoring/ruby/ui/tree/
ElementGripFactory.java,v  <--  ElementGripFactory.java
new revision: 1.2; previous revision: 1.1
done
Checking in kit/nbproject/project.xml;
/cvs/scripting/ruby/kit/nbproject/project.xml,v  <--  project.xml
new revision: 1.101; previous revision: 1.100
done
Checking in refactoring/nbproject/project.xml;
/cvs/scripting/ruby/refactoring/nbproject/project.xml,v  <--  project.xml
new revision: 1.4; previous revision: 1.3
done
IDE: [6/11/07 9:35 AM] Committing finished
Comment 4 Torbjorn Norbye 2007-06-11 19:00:01 UTC
I see one more problem, will be fixing shortly - don't test it quite yet
Comment 5 Torbjorn Norbye 2007-06-11 19:25:08 UTC
Ok, as of build 1880 it should be ready.
Comment 6 Jiri Kovalsky 2007-07-03 13:57:52 UTC
Reassigning this issue to newly created 'ruby' component.
Comment 7 Jiri Kovalsky 2007-07-03 14:41:50 UTC
Changing target milestone of all resolved Ruby issues from TBD to 6.0 Beta 1 build.
Comment 8 Tomas Danek 2007-10-23 16:05:56 UTC
unable to reproduce, comment is renamed properly. verified in 20071023