This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 105318 - Edit JSP source from webform context menu does not work
Summary: Edit JSP source from webform context menu does not work
Status: RESOLVED DUPLICATE of bug 115596
Alias: None
Product: obsolete
Classification: Unclassified
Component: visualweb (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Quy Nguyen
URL:
Keywords: REGRESSION
: 102533 (view as bug list)
Depends on: 58136
Blocks:
  Show dependency tree
 
Reported: 2007-05-31 21:30 UTC by _ krystyna
Modified: 2007-09-15 01:41 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ krystyna 2007-05-31 21:30:52 UTC
NB trunk build 05310000
XP
JDK1.6.0_01

Both Outline and Webform have context menu entry to "Edit JSP Source" but it 
is a no-op. Workaround by going directly to JSP via webform JSP tab.

Regression from 5.5.1
Comment 1 Peter Zavadsky 2007-05-31 23:38:36 UTC
It works for both cases for me. Does it only happen with JDK 6?
Comment 2 _ krystyna 2007-06-01 00:14:27 UTC
It fails with both jdk1.5.0_11 and 1.6.0_01 on a new 
project. Once you click on JSP tab, context menu will 
then always open to JSP source. So:

1. Close all projects in multiview and restart IDE 
(a fresh userdir is not necessary) and create a new project
2. context menu on webform - context menu to edit jsp source doesn't work
3. drop a button on webform - context menu to edit jsp source still doesn't work
4. click on JSP tab to open to JSP source, close, return to designer, and then 
try context menu to edit jsp source - then it will work.
5. next new project you will get same behavior as above steps.
Comment 3 Peter Zavadsky 2007-06-01 18:51:42 UTC
OK, so the problem occures only after the project is created, and after one
switches to JSP by hand, it goes away.

Anyway, I've checked that the action calls edit cookie on JsfJspDataObject, and
why it doesn't work is up to the loader (there is some suspicious 'redirect' API
present).

Passing to the owner.
Comment 4 _ krystyna 2007-07-21 00:31:11 UTC
Problem is still here: trunk build 0720
Comment 5 Quy Nguyen 2007-08-30 01:14:36 UTC
*** Issue 102533 has been marked as a duplicate of this issue. ***
Comment 6 Quy Nguyen 2007-08-30 01:16:57 UTC
Fixed the JSP open context menu entry.

Checking in src/org/netbeans/modules/visualweb/project/jsfloader/JsfJavaEditorSupport.java;
/cvs/visualweb/project/jsfloader/src/org/netbeans/modules/visualweb/project/jsfloader/JsfJavaEditorSupport.java,v  <-- 
JsfJavaEditorSupport.java
new revision: 1.5; previous revision: 1.4
done
Checking in src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspEditorSupport.java;
/cvs/visualweb/project/jsfloader/src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspEditorSupport.java,v  <-- 
JsfJspEditorSupport.java
new revision: 1.4; previous revision: 1.3
done
Comment 7 _ krystyna 2007-09-06 00:05:04 UTC
Verified fixed in NetBeans IDE 6.0 Beta 1 (Build 200709050000) 
Java: 1.6.0_01; Java HotSpot(TM) Client VM 1.6.0_01-b06
Comment 8 Quy Nguyen 2007-09-12 20:43:52 UTC
Fix backed out.  It caused pages opened when a project is opened to be in the JSP tab (since the NB project open
facility uses the edit action by default).

Checking in src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspDataObject.java;
/cvs/visualweb/project/jsfloader/src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspDataObject.java,v  <-- 
JsfJspDataObject.java
new revision: 1.10; previous revision: 1.9
done
Comment 9 Quy Nguyen 2007-09-12 21:11:17 UTC
Since the underlying issue (58136) looks like it will not be fixed for NB 6, we should find a workaround since the edit
action is broken again.  The 'edit' action on the .jsp file node in the projects tab will not be fixed, but at least the
'view jsp source' action should do the correct thing.  Since the ViewJspSource action is in insync, perhaps an
additional Node.Cookie interface could be created specifically for this.
Comment 10 _ sandipchitale 2007-09-13 01:50:51 UTC
Assigning back to Quy as Insync action is doing the right thing.
Comment 11 Quy Nguyen 2007-09-15 01:41:51 UTC

*** This issue has been marked as a duplicate of 115596 ***