This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 102354 - Memory leak in MakeLogicalViewProvider
Summary: Memory leak in MakeLogicalViewProvider
Status: CLOSED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P1 blocker (vote)
Assignee: Vladimir Voskresensky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-24 15:55 UTC by Vladimir Voskresensky
Modified: 2007-11-27 16:32 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Voskresensky 2007-04-24 15:55:48 UTC 
MakeLogicalViewProvider holds MakeProject after closing it in IDE.
The reason is the static fields 
    private static Project currentProject = null;
    private static Folder currentFolder = null;
which holds the hard references to the closed project.
FindUsages shows, that this fields are only assigned, but never used => it is
something like legacy or not cleaned up code.
The fix is safe.
Comment 1 Vladimir Voskresensky 2007-04-24 17:33:18 UTC 
integrated fix with one comment.
there is a call to getMakeConfigurationDescriptor().getLogicalFolders(); and
result remembered in field which I removed. I don't know the side effect of
calling of this method => I left the call while removed remembering in field
(the reason of memory leak)

cvs log:
Checking in MakeLogicalViewProvider.java;
/shared/data/ccvs/repository/cnd/makeproject/src/org/netbeans/modules/cnd/makeproject/ui/MakeLogicalViewProvider.java,v
 <--  MakeLogicalViewProvider.java
new revision: 1.1.2.12.6.21; previous revision: 1.1.2.12.6.20
done