This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | I18N - Some parts of go to class window do not fully appear in other locales when translated and/or using larger font sizes | ||
---|---|---|---|
Product: | editor | Reporter: | Ken Frank <kfrank> |
Component: | -- Other -- | Assignee: | issues@editor <issues> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | jrojcek |
Priority: | P2 | Keywords: | I18N |
Version: | 3.x | ||
Hardware: | Sun | ||
OS: | Solaris | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 33246 | ||
Attachments: |
gif of image overlapping areas
gif - after resizing it hardcoded GoToClass dialog view |
Description
Ken Frank
2003-05-29 18:27:38 UTC
Created attachment 10518 [details]
gif of image overlapping areas
Created attachment 10519 [details]
gif - after resizing it
Go To Class dialog belongs to Editor. fixed in [maintrunk] /cvs/editor/libsrc/org/netbeans/editor/ext/java/JavaFastOpenPanel.java,v <-- JavaFastOpenPanel.java new revision: 1.12; previous revision: 1.11 /cvs/editor/src/org/netbeans/modules/editor/java/NbJavaFastOpen.java,v <-- NbJavaFastOpen.java new revision: 1.14; previous revision: 1.13 The fix also includes the fix of the Go To Class dialog. There was hardcoded textfield for class name and the panel had hardcoded preferred size, that's why label "Matching classes..." is not fully visible. Please look at attached image. Diffs: http://editor.netbeans.org/source/browse/editor/libsrc/org/netbeans/editor/ext/java/JavaFastOpenPanel.java.diff?r1=1.11&r2=1.12 http://editor.netbeans.org/source/browse/editor/src/org/netbeans/modules/editor/java/NbJavaFastOpen.java.diff?r1=1.13&r2=1.14 Jano, could you please review the fix? Thanks. Created attachment 10671 [details]
hardcoded GoToClass dialog view
Reviewed. The fix looks good. Only a minor comment is about setting the preferred size to null. It is required only if it is hard coded to a non-default value somewhere before. Otherwise it is not needed. Yes, just like expField, that is hardcoded in guarded part. I don't want to change the form file because of easier diffs in this case. As for setting preferred size of JavaFastOpenPanel it is really redundant. Thanks for review! integrated into [release35] /cvs/editor/libsrc/org/netbeans/editor/ext/java/JavaFastOpenPanel.java,v <-- JavaFastOpenPanel.java new revision: 1.11.24.1; previous revision: 1.11 /cvs/editor/src/org/netbeans/modules/editor/java/NbJavaFastOpen.java,v <-- NbJavaFastOpen.java new revision: 1.13.2.1; previous revision: 1.13 integrated in [prj40_prototype] also /cvs/java/editor/libsrc/org/netbeans/editor/ext/java/Attic/JavaFastOpenPanel.java,v <-- JavaFastOpenPanel.java new revision: 1.1.2.1.4.2; previous revision: 1.1.2.1.4.1 /cvs/java/editor/src/org/netbeans/modules/editor/java/Attic/NbJavaFastOpen.java,v <-- NbJavaFastOpen.java new revision: 1.1.2.1.2.2.2.9; previous revision: 1.1.2.1.2.2.2.8 Build : S1Studio0617 ML Build Pseudolocalized : Yes OS : Win2k ZH and Sol9 Zh Verified that the above fix works. Hence marking the bug as verified. Thanks Naveen |