This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 34021 - I18N - Some parts of go to class window do not fully appear in other locales when translated and/or using larger font sizes
Summary: I18N - Some parts of go to class window do not fully appear in other locales ...
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: Sun Solaris
: P2 blocker (vote)
Assignee: issues@editor
URL:
Keywords: I18N
Depends on:
Blocks: 33246
  Show dependency tree
 
Reported: 2003-05-29 18:27 UTC by Ken Frank
Modified: 2007-11-05 13:44 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
gif of image overlapping areas (6.92 KB, image/gif)
2003-05-29 22:29 UTC, Ken Frank 		Details
gif - after resizing it (9.51 KB, image/gif)
2003-05-29 22:31 UTC, Ken Frank 		Details
hardcoded GoToClass dialog view (19.94 KB, image/jpeg)
2003-06-12 14:27 UTC, Martin Roskanin 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2003-05-29 18:27:38 UTC 
Using pseudo localized product, with each message
or label
having additional multibyte text, and using
-fontsize 16
option, running in Chinese locale,

tools->goto class

the warning window that says you need to have a
mounted file system (see attachment image)
has some overalapped areas.
Chinese localization will use a larger font than
default
one now used so these issues will be more visible
to them,
but this can also be viewed as a general or a11y
issue
since may be visible to users in english locale
who use
larger fonts.

Assumption is that user should be able to see
all items in a given window when it appears and
should
not need to resize it to see those things.

That is, the UI area or window should dynamically
resize
itself to show the needed contents.
(this does not apply to contents of textfields,
areas
controlled by scrollbars or vertical resizing
controls
like in options window)

To emulate in non multibyte locale without
multibyte
in messages or longer messages, you may need to
run
with fontsize 18 or 20 to see what we are seeing
with
fontsize 16.

Can team also review resizing and fontsizing
approach
in general for other parts of modules ? 
Docs and others have requested that for
3.5.X and Nevada that no fixes involve actual
changing
of UI like adding, modifying or deleting a message
or UI
component as part of fixing these issues.

This issue is marked with the FONTSIZE keywork;
bugs so
marked will not appear on quality dashboards and
will not
need to be waived or fixed for English FCS
products of this
release.

For Netbeans issues, this will be marked as
blocking 33246.
Comment 1 Ken Frank 2003-05-29 22:29:58 UTC 
Created attachment 10518 [details]
gif of image overlapping areas
Comment 2 Ken Frank 2003-05-29 22:31:02 UTC 
Created attachment 10519 [details]
gif - after resizing it
Comment 3 Tomas Hurka 2003-06-11 09:25:21 UTC 
Go To Class dialog belongs to Editor.
Comment 4 Martin Roskanin 2003-06-12 14:09:14 UTC 
fixed in [maintrunk]

/cvs/editor/libsrc/org/netbeans/editor/ext/java/JavaFastOpenPanel.java,v
 <--  JavaFastOpenPanel.java
new revision: 1.12; previous revision: 1.11

/cvs/editor/src/org/netbeans/modules/editor/java/NbJavaFastOpen.java,v
 <--  NbJavaFastOpen.java
new revision: 1.14; previous revision: 1.13
Comment 5 Martin Roskanin 2003-06-12 14:26:24 UTC 
The fix also includes the fix of the Go To Class dialog. There was
hardcoded textfield for class name and the panel had hardcoded
preferred size, that's why label "Matching classes..." is not fully
visible. Please look at attached image.

Diffs:
http://editor.netbeans.org/source/browse/editor/libsrc/org/netbeans/editor/ext/java/JavaFastOpenPanel.java.diff?r1=1.11&r2=1.12
http://editor.netbeans.org/source/browse/editor/src/org/netbeans/modules/editor/java/NbJavaFastOpen.java.diff?r1=1.13&r2=1.14

Jano, could you please review the fix? Thanks.
Comment 6 Martin Roskanin 2003-06-12 14:27:24 UTC 
Created attachment 10671 [details]
hardcoded GoToClass dialog view
Comment 7 jrojcek 2003-06-12 14:43:01 UTC 
Reviewed. The fix looks good. Only a minor comment is about setting
the preferred size to null. It is required only if it is hard coded to
a non-default value somewhere before. Otherwise it is not needed.
Comment 8 Martin Roskanin 2003-06-12 15:19:50 UTC 
Yes, just like expField, that is hardcoded in guarded part. I don't
want to change the form file because of easier diffs in this case. As
for setting preferred size of JavaFastOpenPanel it is really
redundant. Thanks for review!
Comment 9 Martin Roskanin 2003-06-13 14:04:37 UTC 
integrated into [release35]

/cvs/editor/libsrc/org/netbeans/editor/ext/java/JavaFastOpenPanel.java,v
 <--  JavaFastOpenPanel.java
new revision: 1.11.24.1; previous revision: 1.11

/cvs/editor/src/org/netbeans/modules/editor/java/NbJavaFastOpen.java,v
 <--  NbJavaFastOpen.java
new revision: 1.13.2.1; previous revision: 1.13
Comment 10 Martin Roskanin 2003-06-17 14:46:39 UTC 
integrated in [prj40_prototype] also

/cvs/java/editor/libsrc/org/netbeans/editor/ext/java/Attic/JavaFastOpenPanel.java,v
 <--  JavaFastOpenPanel.java
new revision: 1.1.2.1.4.2; previous revision: 1.1.2.1.4.1

/cvs/java/editor/src/org/netbeans/modules/editor/java/Attic/NbJavaFastOpen.java,v
 <--  NbJavaFastOpen.java
new revision: 1.1.2.1.2.2.2.9; previous revision: 1.1.2.1.2.2.2.8
Comment 11 naveen 2003-06-25 10:31:34 UTC 
Build : S1Studio0617 ML Build
Pseudolocalized : Yes
OS : Win2k ZH and Sol9 Zh

Verified that the above fix works. Hence marking the bug as verified.

Thanks
Naveen