This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 183709 - Repaints with missing highlights (as plain text)
Summary: Repaints with missing highlights (as plain text)
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Painting & Printing (show other bugs)
Version: 6.x
Hardware: PC Mac OS X
: P2 normal (vote)
Assignee: Vitezslav Stejskal
URL:
Keywords:
: 182990 183165 183395 183800 183871 183892 183909 184231 184311 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-04-08 13:36 UTC by Miloslav Metelka
Modified: 2010-04-17 08:13 UTC (History)
10 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miloslav Metelka 2010-04-08 13:36:38 UTC 
There are frequent repaints (view rebuilds) when the text is rendered plain.
With fix of issue #182900 (which uses RP for re-posting of the highlights changes) this is somewhat more visible.
It's possibly because once the highlight layers report a change they can no longer provide data for an ongoing highlights sequence requested during view's rebuild. If this is a source of the problem then possibly once HighlightsViewFactory.fetchNextHighlight() is called and no next highlight gets returned it should possibly check for HVF.affectedRangeStart/EndOffset (needs monitor like in getAndClearAffectedRange()) and if it affects the current area for which the highlights are being read then a new highlights sequence should be requested immediately in fetchNextHighlight(). The affected area should probably be retained as is (though the factory is already incorporating the new highlights that were fired) since the just fired range may span beyond the area where the views are being currently rebuilt so it would be somewhat complicated to handle that properly.
Comment 1 Miloslav Metelka 2010-04-08 13:54:48 UTC 
We could also possibly consider a fix where the view factories would notify directly and the affected area coalescing would be done in the view hierarchy infrastructure. This way the the VH infrastructure could break the ongoing view rebuilding process once any view factory fires a change.
Comment 2 Vitezslav Stejskal 2010-04-10 04:36:28 UTC 
*** Bug 183165 has been marked as a duplicate of this bug. ***
Comment 3 David Strupl 2010-04-13 13:17:53 UTC 
*** Bug 183892 has been marked as a duplicate of this bug. ***
Comment 4 David Strupl 2010-04-13 13:18:25 UTC 
*** Bug 183909 has been marked as a duplicate of this bug. ***
Comment 5 Vitezslav Stejskal 2010-04-15 11:02:56 UTC 
*** Bug 184231 has been marked as a duplicate of this bug. ***
Comment 6 Vitezslav Stejskal 2010-04-15 12:54:23 UTC 
*** Bug 182990 has been marked as a duplicate of this bug. ***
Comment 7 Vitezslav Stejskal 2010-04-15 12:55:09 UTC 
*** Bug 183871 has been marked as a duplicate of this bug. ***
Comment 8 Vitezslav Stejskal 2010-04-16 07:51:07 UTC 
http://hg.netbeans.org/jet-main/rev/787d4297d4c6
Comment 9 Vitezslav Stejskal 2010-04-16 09:03:15 UTC 
*** Bug 183395 has been marked as a duplicate of this bug. ***
Comment 10 Vitezslav Stejskal 2010-04-16 11:28:40 UTC 
*** Bug 183800 has been marked as a duplicate of this bug. ***
Comment 11 Vitezslav Stejskal 2010-04-16 11:33:03 UTC 
*** Bug 184311 has been marked as a duplicate of this bug. ***
Comment 12 Quality Engineering 2010-04-17 08:13:48 UTC 
Integrated into 'main-golden', will be available in build *201004170515* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/787d4297d4c6
User: Vita Stejskal <vstejskal@netbeans.org>
Log: #183709: fixing repaints; do not use stale HighlightsSequence, but ask the container for a new sequence