This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | BaseDocumentEvent prevents managing undoable edits in a reasonable way | ||
---|---|---|---|
Product: | editor | Reporter: | Nathan Fiedler <nlfiedler> |
Component: | -- Other -- | Assignee: | issues@editor <issues> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | ||
Priority: | P1 | ||
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 81655, 83624 |
Description
Nathan Fiedler
2006-08-30 07:29:13 UTC
Raising to P1, as the team agreed that this blocks our progress in this area. Either this needs to be fixed or we need someone in NetBeans to explain how to work around the issue. OK, I will remove the assertion. It was useful when the CloneableEditorSupport did the adding of the undoable events asynchronously to prevent BaseDocument <-> UndoManager deadlocks - to ensure that there will not be undo called prior physical adding of the undoable edit to the UndoManager (or more precisely CES.getUndoRedo()). However Yarda has changed the UM in CES to first write-lock the document to avoid the deadlocks and restored synchronous adding of the UEs. I hope that you reuse the UM from CES.getUndoRedo() for your solution - otherwise you would have two active UMs which would be problematic. Fixed in trunk: Checking in BaseDocumentEvent.java; /cvs/editor/libsrc/org/netbeans/editor/BaseDocumentEvent.java,v <-- BaseDocumentEvent.java new revision: 1.26; previous revision: 1.25 I will integrate into release55 branch as well. Integrated into release55: Checking in libsrc/org/netbeans/editor/BaseDocumentEvent.java; /cvs/editor/libsrc/org/netbeans/editor/BaseDocumentEvent.java,v <-- BaseDocumentEvent.java new revision: 1.24.40.2; previous revision: 1.24.40.1 |