This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Wizard framework cannot use Progress API | ||
---|---|---|---|
Product: | platform | Reporter: | Jiri Rechtacek <jrechtacek> |
Component: | Progress | Assignee: | Milos Kleint <mkleint> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | jglick, jtulach, pjiricka |
Priority: | P2 | Keywords: | API, API_REVIEW_FAST |
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | 34699 | ||
Bug Blocks: | 58889 | ||
Attachments: | progress api split changes |
Description
Jiri Rechtacek
2006-06-20 15:37:14 UTC
as discussed offline: progress depends on org.openide.dialogs and org.openide.windows. we should use reflection in either wizards or progress to get rid of circular dependencies. splitting the progress APIs and impl would mean an incompatible change for the API users. (as it's users need to declare required token next to the module dependency.) +1 for splitting API from impl. Have API find impl in lookup and include a trivial implementation if none is found, which would e.g. do nothing or just use logging to notify progress. Re. compatibility for progress API users, not a big problem. Even as things stand you can use ModuleAutoDeps. But with issue #34699 you would be able to e.g. ---%<--- core/progress/api/manifest.mf +OpenIDE-Module-Recommends: org.netbeans.modules.progress.spi.ProgressImpl ---%<--- which would have no impact on users. Properly marking deps. done the split of progress api and ui. Api now depends on openide/util only. progress ui has implementation dependency on progress api and progress api uses the OpenIDE-Modules-Needs token. increased the version number and updated the apichanges document. diff attached. Created attachment 32144 [details]
progress api split changes
please review, diff attached. BTW please: echo 'diff -u' >> ~/.cvsrc No need to cast after calling Lookup.gD().lookup(PUIWP.class). Class name org.netbeans.progress.spi.ProgressUIWorkerProvider does not match token org.netbeans.spi.progress.ProgressUIWorkerProvider. Which is it? Delete layer if empty. the token should be based on the class. yarda made me change the package name, but the token got lost on the way. thanks for feedback, about to integrate integrated in trunk. |