This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | assert in BasicBrandingModel.initBundleKeys | ||
---|---|---|---|
Product: | apisupport | Reporter: | pzajac <pzajac> |
Component: | Project | Assignee: | Jesse Glick <jglick> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | jchalupa, pjiricka, rmatous |
Priority: | P1 | ||
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
assert.txt
This diff contains additional assert that isn't satisfied when the problem occures Suggested fix |
Description
pzajac
2006-02-02 15:20:34 UTC
Created attachment 28718 [details]
assert.txt
I've seen it too, but for me reproducible only randomly. I am able reproduce it every time. Thrown (acc. to pzajac, though not reported here) when selecting 5.5 platform. Seems that org/netbeans/core/startup/Bundle.properties#currentVersion is undefined. Why?? This key in core/startup is fine. And ide/branding/core/startup/src/org/netbeans/core/startup/Bundle_nb.properties on release55 has as expected: currentVersion=NetBeans 5.5 Preview (Build {0}) In any event, apisupport should not throw assertions just because some bundle key is missing. But root cause needs to be investigated. Yes, I can reproduce it when is selected nb55 platform. suiteProperties.getActivePlatform().getModules() returns array of ModuleEntry-ies but platform6/core/core.jar is sometimes not present in nb55. "platform6/core/core.jar is sometimes not present in nb55" - ??? I'm somehow confused with this issue. I expect this issue is right reported against 5.0u1 and the problem occures when you use 5.0u1 build for developing suite against nb5.5. Im I right ? In any case I'm not able to reproduce neither in 5.0u1 build nor in 5.5 (in both cases I developed against 5.5). Maybe I'm doing something wrong. Anyway I tested it on Linux not on Windows. I can naturally strip those asserts but I would rather find the cause. Please, forget my comment about missing platform6/core/core.jar in nb55 (just my mistake). The actual apisupport code throwing the assertion is that of 5.0. Awaiting further details to reproduce the problem. How to reproduce: 1) Install the netbeans-5_5-preview with appserver distribution 2) Create a module suite 3) Show propperties of module suite 4) The exception was thrown I was talking about that with Radek. He told me he is able to reproduce it. Evaluation: There are two modules containing the same localized name ("Startup"): /platform6/core/core.jar /infra2/modules/com-sun-tools-ide-startup.jar For their ModuleEntry-ies is true that compareTo (implemented in AbstractEntry) returns 0 and then method NbPlatform.getModules() doesn't return ModuleEntry for org.netbeans.core.startup. Created attachment 28765 [details]
This diff contains additional assert that isn't satisfied when the problem occures
Created attachment 28771 [details]
Suggested fix
Fix looks correct to me. I thought I had caught all such unsafe comparators a few months ago, but apparently not. Should IMHO go into trunk, javaee5, and apisupport_50u1. release55 merge, please verify: Checking in project/src/org/netbeans/modules/apisupport/project/universe/AbstractEntry.java; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/universe/AbstractEntry.java,v <-- AbstractEntry.java new revision: 1.3.8.1.2.1; previous revision: 1.3.8.1 done Merged to apisupport_50u1, trunk merge coming soon... Checking in AbstractEntry.java; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/universe/AbstractEntry.java,v <-- AbstractEntry.java new revision: 1.7.2.1; previous revision: 1.7 done Trunk: committed Up-To-Date 1.8 apisupport/project/src/org/netbeans/modules/apisupport/project/universe/AbstractEntry.java And javaee5: Checking in AbstractEntry.java; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/universe/AbstractEntry.java,v <-- AbstractEntry.java new revision: 1.3.8.2; previous revision: 1.3.8.1 done verified in nb55(last week) |