This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | InstanceDataObjectModuleTest7.testFixedSettingsChangeInstanceAfterSlowReload can leave m2 enabled | ||
---|---|---|---|
Product: | platform | Reporter: | Jesse Glick <jglick> |
Component: | Module System | Assignee: | Jesse Glick <jglick> |
Status: | CLOSED FIXED | ||
Severity: | blocker | CC: | jtulach |
Priority: | P3 | Keywords: | TEST |
Version: | 4.x | ||
Hardware: | Sun | ||
OS: | Solaris | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Jesse Glick
2004-12-20 17:25:42 UTC
committed Up-To-Date 1.11 core/test/unit/src/org/netbeans/core/lookup/InstanceDataObjectModuleTestHid.java Fails every second day with message bellow. Probably the logging is not correct? testFixedSettingsChangeInstanceAfterSlowReload: java.lang.IllegalArgumentException: enabled module: Module:test2 at org.netbeans.core.modules.ModuleManager.delete(ModuleManager.java:615) at org.netbeans.core.lookup.InstanceDataObjectModuleTestHid$2.run(InstanceDataObjectModuleTestHid.java:113) at org.openide.util.Mutex.writeAccess(Mutex.java:310) at org.netbeans.core.lookup.InstanceDataObjectModuleTestHid.tearDown(InstanceDataObjectModuleTestHid.java:110) at org.netbeans.core.lookup.InstanceDataObjectModuleTest7.tearDown(InstanceDataObjectModuleTest7.java:68) at junit.framework.TestCase.runBare(TestCase.java:130) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at org.netbeans.junit.NbTestCase.run(NbTestCase.java:119) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at org.netbeans.xtest.testrunner.JUnitTestRunner.runTests(JUnitTestRunner.java:176) at org.netbeans.xtest.testrunner.JUnitTestRunner.runTests(JUnitTestRunner.java:127) at org.netbeans.xtest.plugin.jvm.JUnitTestRunnerLauncher.main(JUnitTestRunnerLauncher.java:41) The logging was indeed not correct. The actual error was apparently caused by some failure in the test body, which the tearDown method did not handle correctly. I fixed that. I then found some other use of try-finally in the test body which was unnecessary and possibly could result in meaningless errors, which I also fixed. I also made sure that the test is only run with the correct classpath as it can fail strangely if not. Then it passes for me. I presume that somewhere in there, there was some actual test failure, but now I cannot find it. If it happens again, at least the error message should be more sensible. Let's try again. committed * Up-To-Date 1.11 core/test/unit/src/org/netbeans/core/lookup/InstanceDataObjectModuleTest7.java committed * Up-To-Date 1.12 core/test/unit/src/org/netbeans/core/lookup/InstanceDataObjectModuleTestHid.java Verified. |