This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | I18N - The text in Java Navigation component does not fully appear if it's too long | ||
---|---|---|---|
Product: | java | Reporter: | Ken Frank <kfrank> |
Component: | Unsupported | Assignee: | Jan Pokorsky <jpokorsky> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | Keywords: | I18N |
Priority: | P2 | ||
Version: | 3.x | ||
Hardware: | Sun | ||
OS: | Solaris | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 33246, 45719 | ||
Attachments: |
gif of the combo box
the patch attempting to work around combobox disability via puggable renderer NPEs thrown by swing code |
Description
Ken Frank
2003-05-27 22:45:00 UTC
Created attachment 10472 [details]
gif of the combo box
Java Navigation component belongs to java module. Reassigning to java. This issue was caused by fix of issue #24170. Reassigning to Mila, who worked on issue #24170. The java navigation view should be sized so that the selected value of the navigation view is visible but rest of the toolbar remains visible too. Ideally the editor toolbar should allow its components (including java navigation view) to specify if they wish to cover the width remaining after subtracting width of the remaining icons in the toolbar. A general solution would have to solve a case when there would be multiple such components in the toolbar. I remember that initially we have tested the variable size navigation view when the editor toolbar was established but there were issues with sudden changes of the navigation view width (based on results of parsing) so we have chosen a fixed width instead. However we should try again to find a good solution for this problem in 4.0. As there is no easy fix for this issue I would like to request this issue to be waived till 4.0. I have been investigating possibility to solve this issue with an adapted combobox. The default implementation of the combobox uses same width for both the component in toolbar and the list in popup menu. The adapted comobox would preserve the combobox width but it would modify width of the popup menu that contains list of the java hierarchy elements. --------- --------- |Class v| |Class v| --------- -------------------- |longmeth| |longmethod | |longlong| |longlongmethod | |... | |... | |... | |... | --------- -------------------- orig. impl adapted combobox Performence should not be hurt. It is not necessary to compute the size when user opens a source file. Drawback of this solution is in missing api allowing to customize the combobox on that level. I have prepared a patch able to do that but it is not reliable enough. Some swing components throws NPEs randomly. I would not recommend to integrate such a piece of code. We should rather consider to use a custom component capable properly display the popupmenu with the list or try another UI approach. Created attachment 13265 [details]
the patch attempting to work around combobox disability via puggable renderer
Created attachment 13266 [details]
NPEs thrown by swing code
Moving target milestone -> 3.6 3.6 Waiver Request: We've evaluated several solutions and none of them really satisfied original requirement, as there is not enough space in the toolbar. The most promising solution/hack (change size of listbox attached to combobox) throws random exception in swing component. No objection to waiver received - marking as 3.6_WAIVER_APPROVED Milo, are you going to fix it for promo-D? No, sorry, I have no time to fix this one currently. I hope that Honza Pokorsky will find some time to fix it. The last proposed solution seemed nicest to me but I'm not sure whether the problematic NPEs thrown by Swing could be resolved. OK, reassigning to Honza I have come with easier solution. Items that are too long gets a tool tip. fixed in /cvs/java/src/org/netbeans/modules/java/ui/NavigationView.java new revision: 1.24; previous revision: 1.23 Verified. --- NetBeans IDE Dev (Build 070214) 1.6.0; Java HotSpot(TM) Server VM 1.6.0-b105 Linux version 2.6.12-1.1390_FC4smp running on i386 en_US (nb); UTF-8 |