This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | I18N - no way for l10n to set global font size | ||
---|---|---|---|
Product: | platform | Reporter: | Ken Frank <kfrank> |
Component: | Window System | Assignee: | mslama <mslama> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | dsimonek, jf4jbug, jglick, mmirilovic, tboudreau |
Priority: | P2 | Keywords: | I18N |
Version: | 3.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 33246 | ||
Attachments: |
Diff
Diff with changed bundle key name |
Description
Ken Frank
2003-05-12 19:19:33 UTC
Also, -fontsize should override the value from bundle file; as well as explicit font size settings in theme file Please waive this for 3.5 and S1S nevada english releases - this is for Chinese release which happens after english one. I don't think it's a stopper for 3.5 / s1s5 releases, too. Tim please do you know anything about global fontsize in IDE? Where is it defined? org.netbeans.core.Main, I think. Please make clear what exact solution should be. Currently default font size is taken from UIManager (for current L&F which is Metal by default). Do you mean that this should be changed even if parameter fontsize is not used? (by using some key from bundle file?) If there will be no fontsize param and no key in bundle default L&F will be used. To be clear this could be as follows: IF command line param "fontsize" is defined THEN set font size according "fontsize" ELSE IF bundle key "CTL_keyFontSize" is defined THEN set font size according "CTL_keyFontSize" ELSE use default font size from UIManager (L&F) ENDIF Yes, that's the way to do it. If the only way to check the existence of the key (I don't know, I haven't looked at NbBundle closely) is to catch a MissingResourceExecption, maybe have some key like that should be in the bundle if the bundle does not want to specify a font. Yes, you have to catch MRE to check for existence of a key. Suggest just putting in the default bundle: CTL_keyFontSize= and check for an empty value. Here is diff of patch. Test for bundle key is performed AFTER command line parameters are set. If uiFontSize is already set from command line nothing is done. If uiFontSize is not set already bundle key is checked. Created attachment 10530 [details]
Diff
I reviewed the diff and it looks good, although I'd recommend to rename CTL_keyFontSize to something more descriptive, say CTL_globalFontSize ? Created attachment 10568 [details]
Diff with changed bundle key name
Fixed in main trunk. core/src/org/netbeans/core/Bundle.properties r.1.364 core/src/org/netbeans/core/Main.java r.1.163 Reviewed by Dafe. OK. Fix is committed to branch {release35}. verified[030616_1][win2k] if the CTL_keyFontSize property is seted in core/src/org/netbeans/core/Bundle.properties, the default font size in ide will be changed. verified in pseudo localized s1s ml by placing value in the property and starting ide without fontsize value; also, -fontsize does override this value ken.frank@sun.com |