This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Refresh recursively loops | ||
|---|---|---|---|
| Product: | obsolete | Reporter: | tboerkel <tboerkel> |
| Component: | vcsgeneric | Assignee: | Martin Entlicher <mentlicher> |
| Status: | VERIFIED FIXED | ||
| Severity: | blocker | ||
| Priority: | P1 | ||
| Version: | 3.x | ||
| Hardware: | PC | ||
| OS: | Windows ME/2000 | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: |
Loop1
Loop2 Loop3 Loop4 Context diff, that fix this problem. The binary patch, that fixes this issue. |
||
|
Description
tboerkel
2003-03-24 14:14:43 UTC
Created attachment 9499 [details]
Loop1
Created attachment 9500 [details]
Loop2
Creating a new attachment (Loop3) from the start of the refresh commando, maybe useful. Tried after a restart of NB. Created attachment 9501 [details]
Loop3
I am gonna check this now ... stay tuned. Correction: It does not loop, but it takes very very long. Attaching screenshot from the end (Loop4.jpg). Created attachment 9502 [details]
Loop4
This is very strange bug and looks totally unprofessional. This must be definetely fixed into Sun ONE Studio 5.0 and NetBeans 3.5. Thus increasing priority - this is showstopper ! The cache format is the same, but there were some problems with missing statuses etc. which can be corrected with the Recursive Refresh. The result looks really odd, I agree that this is necessary to fix into 3.5. I'll work on a fix in the main trunk in the first place. I've reproduced it, the problem is, that Refresh command returns every folder twice. It's not a bug of RetrievingDialog. On the Empty profile the Rec. Refresh works O.K. The problem was found and fixed in CommandLineVcsDirReader: /cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/CommandLineVcsDirReader.java,v <-- CommandLineVcsDirReader.java new revision: 1.28; previous revision: 1.27 It reported every refreshed file twice - one from passed filesByNames table and once from the data output listener. The data output listener should be used for information only. Please verify in the development builds (20030326 and newer). The diff is here: http://www.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/cmdline/CommandLineVcsDirReader.java.diff?r1=1.27&r2=1.28 Martin, if you want to get the fix in release35, please prepare a diff against that branch _and_ binary patch. Attach them here so ppl can review the diff and test the patch. Thx Created attachment 9543 [details]
Context diff, that fix this problem.
Created attachment 9544 [details]
The binary patch, that fixes this issue.
The binary patch attached. To apply: create folder patches/org-netbeans-modules-vcscore in modules/autoload in the NetBeans 3.5 installation directory and copy the attached Patch32237.jar into that folder: cp Patch32237.jar \ netbeans/modules/autoload/patches/org-netbeans-modules-vcscore Then restart NetBeans. Wonderful, I have just verified the fix using supplied patch in development build #030326 of Sun ONE Studio 5.0. It's a "Go" from QA. The fix is quite simple. Diff looks ok for me. approved by release coordinator for 3.5 Thanks for the review and approval, it's merged into release35 branch: /shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/cmdline/CommandLineVcsDirReader.java,v <-- CommandLineVcsDirReader.java new revision: 1.27.2.1; previous revision: 1.27 Verified in development build #200304132350 of NetBeans 3.5. |