This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | SystemAction.iconResource upgrade problem | ||
|---|---|---|---|
| Product: | platform | Reporter: | Jesse Glick <jglick> |
| Component: | Actions | Assignee: | Jesse Glick <jglick> |
| Status: | CLOSED FIXED | ||
| Severity: | blocker | CC: | dstrupl, jtulach, mihmax, pnejedly |
| Priority: | P3 | Keywords: | API |
| Version: | 3.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 29768 | ||
| Attachments: | Proposed 3.4.1 patch | ||
committed * Up-To-Date 1.62 openide/src/org/openide/util/actions/SystemAction.java added * Up-To-Date 1.1 openide/test/unit/src/org/openide/util/actions/SystemActionTest.java added * Up-To-Date 1.1 openide/test/unit/src/org/openide/util/actions/data/someicon.gif Created attachment 8113 [details]
Proposed 3.4.1 patch
Could someone review this patch? Thanks. Seems OK to me In release341: Checking in openide/src/org/openide/util/actions/SystemAction.java; /cvs/openide/src/org/openide/util/actions/SystemAction.java,v <-- SystemAction.java new revision: 1.56.20.1; previous revision: 1.56 done verified Resolved for 3.4.x or earlier, no new info since then -> closing. |
If possible, make this possible: package foo.bar; public class Baz extends SystemAction { // ... protected String iconResource() {return "path/to/icon.gif";} } where foo/bar/path/to/icon.gif exists. Currently will look only for path/to/icon.gif. Minor 3.3 -> 3.4 compatibility issue; if cannot be fixed, must be documented as such. Workaround: supply a full path prefixed by slash, e.g.: package foo.bar; public class Baz extends SystemAction { // ... protected String iconResource() { return "/foo/bar/path/to/icon.gif"; } } Will produce a warning message in ide.log under 3.4 but should work in both 3.3 and 3.4.