This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Bad debugger colors in Dark Theme | ||
---|---|---|---|
Product: | debugger | Reporter: | Vladimir Voskresensky <vv159170> |
Component: | Code | Assignee: | Martin Entlicher <mentlicher> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ilia, issues |
Priority: | P3 | ||
Version: | 8.2 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | 258613 | ||
Bug Blocks: | |||
Attachments: |
call stack line
break point and program counter program counter with field Colors after "apply" is pressed variant for breakpoint bg color suggested Call Stack color #3E4C61 screen shot of proposed call stack color |
Description
Vladimir Voskresensky
2016-03-31 14:17:26 UTC
Created attachment 159073 [details]
call stack line
used color makes code on the line almost invisible
Created attachment 159074 [details]
break point and program counter
colors used for "breakpoint" line and "program counter" makes user code almost invisible
Ilia, could you, please, propose better color values. Created attachment 159075 [details]
program counter with field
don't break field visibility when provide new program counter color
I can see a bug here. 1) Go to Fonts settings -> Highlighting tab 2) Modify fore/background color for any element 3) Press Apply. Colors in Editor are back to normal (see screenshot). Created attachment 159077 [details]
Colors after "apply" is pressed
And I got this stacktrace when done these actions above in 81beta. It may be related to the current situation, but i haven't checked it yet to be sure. SEVERE [org.openide.util.RequestProcessor]: Error in RequestProcessor org.netbeans.modules.progress.ui.RunOffEDTImpl$3 java.lang.NullPointerException at org.netbeans.modules.options.colors.ColorModel.setAnnotations(ColorModel.java:218) at org.netbeans.modules.options.colors.AnnotationsPanel.applyChanges(AnnotationsPanel.java:285) at org.netbeans.modules.options.colors.FontAndColorsPanel.applyChanges(FontAndColorsPanel.java:266) at org.netbeans.modules.options.colors.FontAndColorsPanelController.applyChanges(FontAndColorsPanelController.java:111) at org.netbeans.modules.options.CategoryModel$Category.applyChanges(CategoryModel.java:401) at org.netbeans.modules.options.CategoryModel$Category.access$1100(CategoryModel.java:326) at org.netbeans.modules.options.CategoryModel.save(CategoryModel.java:222) at org.netbeans.modules.options.OptionsPanel.save(OptionsPanel.java:319) at org.netbeans.modules.options.OptionsDisplayerImpl$OptionsPanelListener$3.run(OptionsDisplayerImpl.java:537) at org.netbeans.modules.progress.ui.RunOffEDTImpl$3.run(RunOffEDTImpl.java:275) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1443) at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:68) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:303) at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2058) Caused: org.openide.util.RequestProcessor$SlowItem: task failed due to at org.openide.util.RequestProcessor.post(RequestProcessor.java:420) at org.netbeans.modules.progress.ui.RunOffEDTImpl.runOffEventThreadCustomDialogImpl(RunOffEDTImpl.java:271) at org.netbeans.modules.progress.ui.RunOffEDTImpl.runOffEventThreadWithCustomDialogContent(RunOffEDTImpl.java:250) at org.netbeans.api.progress.ProgressUtils.runOffEventThreadWithCustomDialogContent(ProgressUtils.java:204) at org.netbeans.modules.options.OptionsDisplayerImpl$OptionsPanelListener.saveOptionsOffEDT(OptionsDisplayerImpl.java:533) at org.netbeans.modules.options.OptionsDisplayerImpl$OptionsPanelListener.actionPerformed(OptionsDisplayerImpl.java:503) at org.netbeans.core.windows.services.NbPresenter$ButtonListener.actionPerformed(NbPresenter.java:1377) at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022) at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348) at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402) at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259) at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252) at java.awt.Component.processMouseEvent(Component.java:6535) at javax.swing.JComponent.processMouseEvent(JComponent.java:3324) at java.awt.Component.processEvent(Component.java:6300) at java.awt.Container.processEvent(Container.java:2236) at java.awt.Component.dispatchEventImpl(Component.java:4891) at java.awt.Container.dispatchEventImpl(Container.java:2294) at java.awt.Component.dispatchEvent(Component.java:4713) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466) at java.awt.Container.dispatchEventImpl(Container.java:2280) at java.awt.Window.dispatchEventImpl(Window.java:2750) at java.awt.Component.dispatchEvent(Component.java:4713) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758) at java.awt.EventQueue.access$500(EventQueue.java:97) at java.awt.EventQueue$3.run(EventQueue.java:709) at java.awt.EventQueue$3.run(EventQueue.java:703) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86) at java.awt.EventQueue$4.run(EventQueue.java:731) at java.awt.EventQueue$4.run(EventQueue.java:729) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76) at java.awt.EventQueue.dispatchEvent(EventQueue.java:728) at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:159) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) [catch] at java.awt.EventDispatchThread.run(EventDispatchThread.java:82) (97,29,29) for Breakpoint background is very good looking Created attachment 159078 [details]
variant for breakpoint bg color
another good variant for breakpoint bg color
(In reply to ilia from comment #6) > Created attachment 159077 [details] > Colors after "apply" is pressed What about "Call Stack" color? Created attachment 159083 [details]
suggested Call Stack color #3E4C61
Created attachment 159084 [details]
screen shot of proposed call stack color
proposed call stack color
Martin, So, as I understand there are two issues: 1) in Dark Theme IDE uses Norway Today color scheme, but Fonts &Colors from Annotations tab are not really used by IDE 2) "Call Site" bg colors used by NorwayToday is bad and makes line invisible https://netbeans.org/bugzilla/attachment.cgi?id=159073 so, color #3E4C61 is proposed to be used instead https://netbeans.org/bugzilla/attachment.cgi?id=159084 2 should be changed in debugger? and 1 should be fixed by whom? Btw, to workaround 1 user can switch to another Scheme in Options dialog, press Apply and then switch to Norway Today and press Apply => colors are applied 1) is similar to issue #231735. Please submit an issue for this in Editor/Options category. The NPE might help to address the issue. 2) There was a fix of dark theme by issue #231617, but the stack color is missing there. Thanks for the proposed color. I'll fix it... Martin, bth "Current program counter*" has light bg as well. #3E4C61 can be used instead Martin, could you apply proposed colors, please. Thanks! VVV Fixed by changeset: 296794:60c7a152ddc5 http://hg.netbeans.org/core-main/rev/60c7a152ddc5 Please check if it works fine for you now. Integrated into 'main-silver', will be available in build *201604170001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/60c7a152ddc5 User: mentlicher@netbeans.org Log: #258606: Adjusted the dark theme colors. |