This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | NB8 ActiveQueue doesn't work properly with JDK9 | ||
---|---|---|---|
Product: | platform | Reporter: | lothe |
Component: | -- Other -- | Assignee: | Jaroslav Tulach <jtulach> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dobs, exceptions_reporter, inonit, Leperous, mmirilovic, Tristan, troodon |
Priority: | P2 | ||
Version: | 8.1 | ||
Hardware: | PC | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | 206621 | ||
Bug Blocks: | 184192 | ||
Attachments: |
More reflection to make the code work on JDK9
Code can be greatly simplified once the removeWhileExists is available |
Description
lothe
2014-07-16 13:57:39 UTC
Regression introduced by
> changeset: 0731952efb10
> user: igerasim
> date: Thu Feb 27 02:44:04 2014 +0400
> summary: 6853696: (ref) ReferenceQueue.remove(timeout) may return null
> even if timeout has not expired
but something that should be addressed on the NetBeans side (as there are nasty tricks with reflection in ActiveQueue which just got broken by the 0731952efb10 change).
Created attachment 148132 [details]
More reflection to make the code work on JDK9
With the previous patch all openide.util.lookup as well as openide.util tests pass on JDK9b04. However I don't like the solution much (even more reflection than before) and will try to come up with proper fix on the JDK side. Rather than hacking on NetBeans side, I decided to share the love and improve JDK: https://bugs.openjdk.java.net/browse/JDK-8051843 Created attachment 148275 [details]
Code can be greatly simplified once the removeWhileExists is available
I won't fix this problem for 8.0.1. Integrated into 'main-silver', will be available in build *201411210001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/0dc25ad5ba37 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #245732: Discussions on JDK's core-libs mailing list revealed that the changes that the API of JDK is enhanced to allow clean fix of the problem is extremlly low, so adding more reflection to make the test work on JDK9 > Regression introduced by
> > changeset: 0731952efb10
> > user: igerasim
> > date: Thu Feb 27 02:44:04 2014 +0400
> > summary: 6853696: (ref) ReferenceQueue.remove(timeout) may return null
> > even if timeout has not expired
> but something that should be addressed on the NetBeans side (as there are nasty tricks with reflection in ActiveQueue which just got broken by the 0731952efb10 change).
was backported to jdk 1.8.0_40
so we should also backport jardas patch to nb 8.0.2
*** Bug 251851 has been marked as a duplicate of this bug. *** backported to releases #f7c199a16490 branch release801 *** Bug 251701 has been marked as a duplicate of this bug. *** *** Bug 252458 has been marked as a duplicate of this bug. *** *** Bug 252246 has been marked as a duplicate of this bug. *** Integrated into 'releases/release801', will be available in build *201505271203* or newer. Wait for official and publicly available build. Changeset: http://hg.netbeans.org/releases/rev/f7c199a16490 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #245732: Discussions on JDK's core-libs mailing list revealed that the changes that the API of JDK is enhanced to allow clean fix of the problem is extremlly low, so adding more reflection to make the test work on JDK9 *** Bug 252806 has been marked as a duplicate of this bug. *** *** Bug 252938 has been marked as a duplicate of this bug. *** available on 8.0.2 Update Center via the following module org.openide.util.lookup [8.25.2 201505281753] *** Bug 253536 has been marked as a duplicate of this bug. *** |