This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Patch for: [Git reset] missing mnemonics for hard, soft, mixed | ||
---|---|---|---|
Product: | versioncontrol | Reporter: | markiewb |
Component: | Git | Assignee: | Ondrej Vrabec <ovrabec> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | git |
Priority: | P3 | Keywords: | A11Y, PATCH_AVAILABLE |
Version: | 7.4 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
Shows the dialog with missing mnemonics
Proposed patch Shows clashes |
Created attachment 134340 [details]
Proposed patch
I like to propose this patch to solve the issue. It only adds the mnemonics to the options. There should be no conflicts within the dialog.
@Ondrej: Please review and commit, if appropriate. Thank you
thanks, pushed as core-main #936dd561bafd Integrated into 'main-golden', will be available in build *201305142300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/936dd561bafd User: Benno Markiewicz <markiewb@netbeans.org> Log: Issue #229630 - [Git reset] missing mnemonics for hard, soft, mixed Created attachment 137655 [details]
Shows clashes
Sorry for reopening the issue. The mnemonic "h" is used twice. See screenshot https://netbeans.org/bugzilla/attachment.cgi?id=137655 (In reply to comment #5) > Sorry for reopening the issue. The mnemonic "h" is used twice. See screenshot > https://netbeans.org/bugzilla/attachment.cgi?id=137655 And I am also sorry, because my patch didn't take this in account. Integrated into 'main-silver', will be available in build *201307242300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/cf1581eed038 User: Ondrej Vrabec <ovrabec@netbeans.org> Log: #229630 - Patch for: [Git reset] missing mnemonics for hard, soft, mixed verified at least in 201308092300 |
Created attachment 134336 [details] Shows the dialog with missing mnemonics ACTUAL in the Git reset dialog there are no mnemonics for the options hard, soft, mixed - see screenshot EXPECTED mnemonics ----- NB 201305092300