This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Make FallbackProvider available outside keyring-impl module | ||
|---|---|---|---|
| Product: | platform | Reporter: | Jan Horvath <jhorvath> |
| Component: | Keyring | Assignee: | Libor Fischmeistr <lfischmeistr> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | lfischmeistr |
| Priority: | P3 | Keywords: | API, API_REVIEW_FAST |
| Version: | 7.3 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Attachments: | Proposed patch | ||
|
Description
Jan Horvath
2013-04-16 15:13:23 UTC
If we want to have fallback provider independent on JNA, we have to separate it to its own new module (keyring.fallback). Because this provider depends on Utils and EncryptionProvider classes, they have to be moved to new module together with it. If changes will be applied, the new keyring.fallback (Keyring Fallback) module will depend on Keyring API module and the Keyring Impl module will depend on Keyring Fallback. So the Keyring Fallback no more depends on the JNA. Please review this change. Patch with the change will be attached immediately. Created attachment 133562 [details]
Proposed patch
(In reply to comment #2) > Created attachment 133562 [details] > Proposed patch The patch looks good for me. Thanks for the review. After more than the ten days without any objections I've pushed the changes into the trunk. Changeset: http://hg.netbeans.org/core-main/rev/e34fab107d29 Integrated into 'main-golden', will be available in build *201305021042* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/e34fab107d29 User: Libor Fischmeistr <lfischmeistr@netbeans.org> Log: #228626: Make FallbackProvider available outside keyring-impl module |