This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 228626 - Make FallbackProvider available outside keyring-impl module
Summary: Make FallbackProvider available outside keyring-impl module
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Keyring (show other bugs)
Version: 7.3
Hardware: All All
: P3 normal (vote)
Assignee: Libor Fischmeistr
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2013-04-16 15:13 UTC by Jan Horvath
Modified: 2013-05-02 14:12 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Proposed patch (13.24 KB, patch)
2013-04-18 11:42 UTC, Libor Fischmeistr 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Horvath 2013-04-16 15:13:23 UTC 
It is desirable to have FallbackProvider available with no dependency on JNA
Comment 1 Libor Fischmeistr 2013-04-18 11:40:49 UTC 
If we want to have fallback provider independent on JNA, we have to separate it to  its own new module (keyring.fallback). Because this provider depends on Utils and EncryptionProvider classes, they have to be moved to new module together with it.

If changes will be applied, the new keyring.fallback (Keyring Fallback) module will depend on Keyring API module and the Keyring Impl module will depend on Keyring Fallback. So the Keyring Fallback no more depends on the JNA.

Please review this change.

Patch with the change will be attached immediately.
Comment 2 Libor Fischmeistr 2013-04-18 11:42:11 UTC 
Created attachment 133562 [details]
Proposed patch
Comment 3 Jiri Rechtacek 2013-04-19 09:29:08 UTC 
(In reply to comment #2)
> Created attachment 133562 [details]
> Proposed patch

The patch looks good for me.
Comment 4 Libor Fischmeistr 2013-04-29 12:54:40 UTC 
Thanks for the review. After more than the ten days without any objections I've pushed the changes into the trunk.

Changeset: http://hg.netbeans.org/core-main/rev/e34fab107d29
Comment 5 Quality Engineering 2013-05-02 14:12:31 UTC 
Integrated into 'main-golden', will be available in build *201305021042* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/e34fab107d29
User: Libor Fischmeistr <lfischmeistr@netbeans.org>
Log: #228626: Make FallbackProvider available outside keyring-impl module