This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Patch for: Inconsistent label format of search vs. search/replace - use choice-format of MessageFormat too | ||
|---|---|---|---|
| Product: | utilities | Reporter: | markiewb |
| Component: | Search | Assignee: | Jaroslav Havlin <jhavlin> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | Keywords: | NETFIX, PATCH_AVAILABLE |
| Priority: | P4 | ||
| Version: | 7.3 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: |
Shows the mismatch and the possible solution
Proposed patch |
||
Created attachment 132093 [details]
Proposed patch
I like to propose a patch to solve this issue. The simple patch only introduces the choice format for some labels.
For example:
Found {0} matching file(s). will
be replaced by
Found {0} matching {0,choice,1#file|1<files}.
@NB-Devs: Please review, discuss and commit! Thank you
>@NB-Devs: Please review, discuss and commit! Thank you The patch is OK. There is not much to discuss, you are right, the messages should be consistent. Thank you very much for providing the patch! Integrated as http://hg.netbeans.org/core-main/rev/886a0ae59c8b Integrated into 'main-golden', will be available in build *201303042300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/886a0ae59c8b User: Jaroslav Havlin <jhavlin@netbeans.org> Log: #226916: Inconsistent label format of search vs. search/replace - use choice-format of MessageFormat too Verified in 201307222300 |
Created attachment 132091 [details] Shows the mismatch and the possible solution The label format of search and search/replace is inconsistent. Please align the label format of s/r to the format of search. Use choice format and use bold format instead of quotes. See screenshot. ACTUAL: Found 8 match(es) of "xxx" in 4 file(s). To be replaced with "foo". Found 1 match(es) of "xxx" in 1 file(s). To be replaced with "foo". EXPECTED: Found 8 matches of xxx in 4 files. To be replaced with foo. Found 1 match of xxx in 1 file. To be replaced with foo.