This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 226906

Summary: Disable verification of plugins depending on build number
Product: updatecenters Reporter: Jiri Kovalsky <jkovalsky>
Component: PluginportalAssignee: Jan Pirek <jpirek>
Status: VERIFIED FIXED    
Severity: normal CC: jrechtacek
Priority: P2 Keywords: PLAN
Version: 7.3   
Hardware: PC   
OS: Linux   
Issue Type: ENHANCEMENT Exception Reporter:
Bug Depends on:    
Bug Blocks: 231766    

Description Jiri Kovalsky 2013-03-01 16:57:27 UTC
In order to avoid dependency of plugins on a concrete build, Plugin Portal should disable to request verification of plugins who use this kind of dependency in their manifests. Honzo, can you please implement this limitation?

If plugin's module descriptor contains something like this [1], display this message [2] under "Request verification".

[1] <module ..><manifest AutoUpdate-Show-In-Client="true" OpenIDE-Module-Module-Dependencies="org.netbeans.modules.php.api.phpmodule = 201302132200,...>

[2] Publishing on the NetBeans Plugin Portal Update Center disabled due to hard dependency on a concrete build number.
Comment 1 Jiri Kovalsky 2013-03-01 16:59:29 UTC
Honzo, can you please take a look at this? Thanks!
Comment 2 Jiri Kovalsky 2013-04-04 09:17:48 UTC
This is a candidate for Plugin Portal 2.2.
Comment 3 Jiri Kovalsky 2013-06-25 10:29:25 UTC
Another bug which would not happen if this is implemented.
Comment 4 Jiri Kovalsky 2013-07-19 11:43:26 UTC
This applies for example this plugin: http://plugins.netbeans.org/plugin/45919
Comment 5 Jan Pirek 2013-07-22 12:36:55 UTC
this is now implemented, any new plugin with such dependency in the info.xml manifest won't be allowed for verification
Comment 6 Jiri Kovalsky 2013-07-25 12:51:57 UTC
Great, thanks Honzo.

Information for plugin owners
=============================
If you want to have the dependency set correctly please consult this FAQ:
http://wiki.netbeans.org/DevFaqImplementationDependency

The point is to NOT use build numbers but module specification versions instead. Here is an example:

1. My plugin depends on org.netbeans.modules.php.api.phpmodule so I must find out its module specification version.
2. Let's say I have NetBeans sources cloned in ~/sources/netbeans directory.
3. cd ~/sources/netbeans/php.api.phpmodule
4. cat manifest.mf

Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.php.api.phpmodule
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/php/api/phpmodule/resources/Bundle.properties
OpenIDE-Module-Specification-Version: 2.19

5. I must modify info.xml of my plugin to contain the following statement:

OpenIDE-Module-Module-Dependencies="org.netbeans.modules.php.api.phpmodule > 2.19"
Comment 7 mcheung63 2017-04-15 07:32:50 UTC
If I use specification, I can't even compile

		<dependency>
			<groupId>org.netbeans.modules</groupId>
			<artifactId>org-netbeans-modules-editor-bookmarks</artifactId>
			<version>1.37.1</version>
		</dependency>

If I use <version>RELEASE82</version>, I can compile, but can't be verify for plugins central :

Plugin has hard dependency to other modules defined in info.xml module descriptor, therefore can't be subject of verification. For more information see issue #226906

PLEASE HELP, THANKS