Bug 226906 - Disable verification of plugins depending on build number
Disable verification of plugins depending on build number
Status: VERIFIED FIXED
Product: updatecenters
Classification: Unclassified
Component: Pluginportal
7.3
PC Linux
: P2 (vote)
: TBD
Assigned To: Jan Pirek
issues@updatecenters
plugin_portal_22
: PLAN
Depends on:
Blocks: 231766
  Show dependency treegraph
 
Reported: 2013-03-01 16:57 UTC by Jiri Kovalsky
Modified: 2013-07-25 12:51 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Kovalsky 2013-03-01 16:57:27 UTC
In order to avoid dependency of plugins on a concrete build, Plugin Portal should disable to request verification of plugins who use this kind of dependency in their manifests. Honzo, can you please implement this limitation?

If plugin's module descriptor contains something like this [1], display this message [2] under "Request verification".

[1] <module ..><manifest AutoUpdate-Show-In-Client="true" OpenIDE-Module-Module-Dependencies="org.netbeans.modules.php.api.phpmodule = 201302132200,...>

[2] Publishing on the NetBeans Plugin Portal Update Center disabled due to hard dependency on a concrete build number.
Comment 1 Jiri Kovalsky 2013-03-01 16:59:29 UTC
Honzo, can you please take a look at this? Thanks!
Comment 2 Jiri Kovalsky 2013-04-04 09:17:48 UTC
This is a candidate for Plugin Portal 2.2.
Comment 3 Jiri Kovalsky 2013-06-25 10:29:25 UTC
Another bug which would not happen if this is implemented.
Comment 4 Jiri Kovalsky 2013-07-19 11:43:26 UTC
This applies for example this plugin: http://plugins.netbeans.org/plugin/45919
Comment 5 Jan Pirek 2013-07-22 12:36:55 UTC
this is now implemented, any new plugin with such dependency in the info.xml manifest won't be allowed for verification
Comment 6 Jiri Kovalsky 2013-07-25 12:51:57 UTC
Great, thanks Honzo.

Information for plugin owners
=============================
If you want to have the dependency set correctly please consult this FAQ:
http://wiki.netbeans.org/DevFaqImplementationDependency

The point is to NOT use build numbers but module specification versions instead. Here is an example:

1. My plugin depends on org.netbeans.modules.php.api.phpmodule so I must find out its module specification version.
2. Let's say I have NetBeans sources cloned in ~/sources/netbeans directory.
3. cd ~/sources/netbeans/php.api.phpmodule
4. cat manifest.mf

Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.php.api.phpmodule
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/php/api/phpmodule/resources/Bundle.properties
OpenIDE-Module-Specification-Version: 2.19

5. I must modify info.xml of my plugin to contain the following statement:

OpenIDE-Module-Module-Dependencies="org.netbeans.modules.php.api.phpmodule > 2.19"


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo