This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Remove BraceCompletion class from java.editor | ||
---|---|---|---|
Product: | editor | Reporter: | Milutin Kristofic <mkristofic> |
Component: | -- Other -- | Assignee: | Milutin Kristofic <mkristofic> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | marfous |
Priority: | P3 | ||
Version: | 7.2 | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | TASK | Exception Reporter: | |
Bug Depends on: | 219830 | ||
Bug Blocks: | |||
Attachments: | Jsp, java cleaning |
Description
Milutin Kristofic
2012-10-10 14:23:21 UTC
Created attachment 127412 [details]
Jsp, java cleaning
Martin I moved removing jsp and java classes from Bug #217163. I tested it and it works same as before. If you approve it, I will push this to jet-main. (In reply to comment #4) > Martin I moved removing jsp and java classes from Bug #217163. > I tested it and it works same as before. > If you approve it, I will push this to jet-main. I'm afraid that I'm just fixer of the jsp serious issues, but the jsp module doesn't have real owner right now. I would like just say that I'm not able to detect all regressions it could make - since I didn't know its sources in detail. :/ I took a look and tested the patch and it looks that it works uniformly. Tests (although there are not much of them) were passing, so feel free to integrate if you are really sure that the change preve Sorry, sent by mistake.
> if you are really sure that the change preve
"preve" -> preserve the same behaviour.
Thanks, I believe this is better then previous state. There were two implementations (typing hooks and java actions) and typing hooks was always firing. http://hg.netbeans.org/jet-main/rev/0a2158c8aef7 Ok, thanks for updating our sources. I just updated the TM. Integrated into 'main-golden', will be available in build *201211100001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/0a2158c8aef7 User: Milutin Kristofic <mkristofic@netbeans.org> Log: #219834 - Remove BraceCompletion class from java.editor |