This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 219834 - Remove BraceCompletion class from java.editor
Summary: Remove BraceCompletion class from java.editor
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 7.2
Hardware: PC Linux
: P3 normal (vote)
Assignee: Milutin Kristofic
URL:
Keywords:
Depends on: 219830
Blocks:
  Show dependency tree
 
Reported: 2012-10-10 14:23 UTC by Milutin Kristofic
Modified: 2012-11-10 03:28 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
Jsp, java cleaning (63.40 KB, patch)
2012-11-08 16:23 UTC, Milutin Kristofic 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Milutin Kristofic 2012-10-10 14:23:21 UTC 
1. Bug #219830 Remove BraceCompletion from recent implementation (TypingHooks implementations)

2. Remove classes extends actions: JavaDeleteCharAction, JavaInsertBreakAction, JavaDefaultKeyTypedAction, JavaDefaultKeyTypedAction.

2a, Remove JavaDeleteCharAction dependency from InstantRenamePerformer

2b, Remove these actions dependency from JspKit
Comment 1 Milutin Kristofic 2012-10-10 14:31:00 UTC 
http://hg.netbeans.org/jet-main/rev/d60f4a92bf65
Comment 2 Milutin Kristofic 2012-10-18 14:24:25 UTC 
2a, http://hg.netbeans.org/jet-main/rev/3c08a33661f6
Comment 3 Milutin Kristofic 2012-11-08 16:23:13 UTC 
Created attachment 127412 [details]
Jsp, java cleaning
Comment 4 Milutin Kristofic 2012-11-08 16:27:10 UTC 
Martin I moved removing jsp and java classes from Bug #217163. 

I tested it and it works same as before.

If you approve it, I will push this to jet-main.
Comment 5 Martin Fousek 2012-11-09 11:03:43 UTC 
(In reply to comment #4)
> Martin I moved removing jsp and java classes from Bug #217163. 
> I tested it and it works same as before.
> If you approve it, I will push this to jet-main.

I'm afraid that I'm just fixer of the jsp serious issues, but the jsp module doesn't have real owner right now. I would like just say that I'm not able to detect all regressions it could make - since I didn't know its sources in detail. :/

I took a look and tested the patch and it looks that it works uniformly. Tests (although there are not much of them) were passing, so feel free to integrate if you are really sure that the change preve
Comment 6 Martin Fousek 2012-11-09 11:04:54 UTC 
Sorry, sent by mistake.

> if you are really sure that the change preve
"preve" -> preserve the same behaviour.
Comment 7 Milutin Kristofic 2012-11-09 12:17:08 UTC 
Thanks, I believe this is better then previous state. There were two implementations (typing hooks and java actions) and typing hooks was always firing.

http://hg.netbeans.org/jet-main/rev/0a2158c8aef7
Comment 8 Martin Fousek 2012-11-09 12:33:13 UTC 
Ok, thanks for updating our sources.
I just updated the TM.
Comment 9 Quality Engineering 2012-11-10 03:28:29 UTC 
Integrated into 'main-golden', will be available in build *201211100001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/0a2158c8aef7
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #219834 - Remove BraceCompletion class from java.editor