This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Do not load editor classes in ModuleInstall | ||
---|---|---|---|
Product: | editor | Reporter: | Jaroslav Tulach <jtulach> |
Component: | -- Other -- | Assignee: | Martin Roskanin <mroskanin> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | msauer |
Priority: | P2 | Keywords: | PERFORMANCE |
Version: | 3.x | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | 24364, 24365, 24366 | ||
Bug Blocks: | 21676 | ||
Attachments: |
The list of all editor premature loaded classes
Classes that remained (63) Classes that remained (50) |
Description
Jaroslav Tulach
2002-03-29 14:44:16 UTC
Please find some time and do the evaluation. . Created attachment 5426 [details]
The list of all editor premature loaded classes
Removing completion lazy init from EditorModule to JavaKit. 12 classes have been saved: org.netbeans.editor.ext.Completion org.netbeans.editor.ext.java.JavaCompletion$BaseType org.netbeans.editor.ext.java.JavaCompletion$JCFinderInitializer org.netbeans.editor.ext.java.JavaCompletion$SimpleClass org.netbeans.editor.ext.java.JavaCompletion org.netbeans.editor.ext.java.JCClass org.netbeans.editor.ext.java.JCConstructor org.netbeans.editor.ext.java.JCField org.netbeans.editor.ext.java.JCMethod org.netbeans.editor.ext.java.JCPackage org.netbeans.editor.ext.java.JCParameter org.netbeans.editor.ext.java.JCType /cvs/editor/src/org/netbeans/modules/editor/EditorModule.java,v <-- EditorModule.java new revision: 1.76; previous revision: 1.75 /cvs/editor/src/org/netbeans/modules/editor/java/JavaKit.java,v <-- JavaKit.java new revision: 1.34; previous revision: 1.33 /cvs/editor/src/org/netbeans/modules/editor/java/NbJavaFastOpen.java,v <-- NbJavaFastOpen.java new revision: 1.8; previous revision: 1.7 Moving DORegistryListener to JavaKit. It is not neccessary to attach listener from EditorModule class, it can be done after JavaKit initialization. Saved class: Loaded org.netbeans.modules.editor.DORegistryListener Removing src/org/netbeans/modules/editor/DORegistryListener.java; /cvs/editor/src/org/netbeans/modules/editor/DORegistryListe ner.java,v <-- DORegistryListener.java new revision: delete; previous revision: 1.7 /cvs/editor/src/org/netbeans/modules/editor/EditorModule.ja va,v <-- EditorModule.java new revision: 1.81; previous revision: 1.80 /cvs/editor/src/org/netbeans/modules/editor/java/JavaKit.ja va,v <-- JavaKit.java new revision: 1.36; previous revision: 1.35 Moving NbEditorSettingsInitializer.init() to NbEditorKit initialization. 8 classes were saved: org.netbeans.modules.editor.plain.NbPlainSettingsInitialize r org.netbeans.modules.editor.NbEditorSettingsInitialize org.netbeans.modules.editor.java.NbJavaSettingsInitializer org.netbeans.modules.editor.html.NbHTMLSettingsInitializer org.netbeans.editor.ext.html.HTMLSettingsInitializer org.netbeans.editor.ext.java.JavaSettingsInitializer org.netbeans.editor.ext.ExtSettingsInitializer org.netbeans.editor.BaseSettingsInitializer /cvs/editor/src/org/netbeans/modules/editor/EditorModule.ja va,v <-- EditorModule.java new revision: 1.82; previous revision: 1.81 /cvs/editor/src/org/netbeans/modules/editor/NbEditorKit.jav a,v <-- NbEditorKit.java new revision: 1.33; previous revision: 1.32 Removing PrintOptions init from EditorModule class. 14 classes were saved: org.netbeans.editor.ext.html.dtd.ReaderProvider org.netbeans.editor.ext.html.dtd.Registry org.netbeans.modules.editor.html.HTMLKit org.netbeans.modules.editor.html.NbReaderProvider$DTDFolder Listener org.netbeans.modules.editor.html.NbReaderProvider$ProviderF olderListener org.netbeans.modules.editor.html.NbReaderProvider$RootFolde rListener org.netbeans.modules.editor.html.NbReaderProvider org.netbeans.modules.editor.java.JavaKit org.netbeans.modules.editor.NbEditorUtilities org.netbeans.modules.editor.options.ContextOptionsListener org.netbeans.modules.editor.options.HTMLPrintOptionsBeanInf o org.netbeans.modules.editor.options.JavaPrintOptionsBeanInf o org.netbeans.modules.editor.options.PlainPrintOptionsBeanIn fo org.netbeans.modules.editor.plain.PlainKit /cvs/editor/src/org/netbeans/modules/editor/EditorModule.ja va,v <-- EditorModule.java new revision: 1.83; previous revision: 1.82 /cvs/editor/src/org/netbeans/modules/editor/NbEditorKit.jav a,v <-- NbEditorKit.java new revision: 1.34; previous revision: 1.33 /cvs/editor/src/org/netbeans/modules/editor/options/BasePri ntOptions.java,v <-- BasePrintOptions.java new revision: 1.26; previous revision: 1.25 /cvs/editor/src/org/netbeans/modules/editor/options/OptionS upport.java,v <-- OptionSupport.java new revision: 1.25; previous revision: 1.24 fixed in [maintrunk] I could remove the other two classes: [Loaded org.netbeans.editor.AnnotationTypes$Loader] [Loaded org.netbeans.editor.AnnotationTypes] but I am not sure whether it will not affect something. As for the rest 61 classes (listed in the attachement), I cannot remove it easily from editor module because some other modules invoke these classes (I mean options related classes) i.e XML editor (some options are not transferred to XML layer.) Some of the classes have to persist in editor ModuleInstall class, such as: [Loaded org.netbeans.modules.editor.EditorModule$RepositListener] [Loaded org.netbeans.modules.editor.EditorModule$RepositOperations] That's why I think the work is done as for editor module and I am closing this bug. Created attachment 6036 [details]
Classes that remained (63)
Martin, please create bugs for other modules that did not upgraded editor settings and make them block this issue. The goal is to identify all sources of problems and get the amount of loaded classes down as much as possible. XML team fixed their issue #24366 that blocked this one. There are two bugs that block this issue, because they are in experimental modules I close this bug. Created attachment 6775 [details]
Classes that remained (50)
Jaroslav could you please verify this issue ? Thanks Jaroslave, could you please verify this issue ? Thanks No I cannot verify, because the classes are still loaded. The code in EditorModule in fact seems to do much more than it used to... Jardo, if you can't verify it, shouldn't it be reopened? Or will you file a new issue? Thanks. I am not going to reopen the issue. I am not going to fire new one in near future. Well, we're trying to clean up Issuezilla, but OK, we'll leave this one as RESOLVED/FIXED. Verified |