This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 24366 - Deprecated editor options registration
Summary: Deprecated editor options registration
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: Text-Edit (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P2 blocker (vote)
Assignee: _ pkuzel
URL:
Keywords: PERFORMANCE
: 25126 (view as bug list)
Depends on: 25207
Blocks: 21976 25126
  Show dependency tree
 
Reported: 2002-06-04 09:03 UTC by Martin Roskanin
Modified: 2007-09-25 01:33 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Proposed patch (against release34 branch). (8.28 KB, patch)
2002-07-17 16:16 UTC, _ lkramolis 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Roskanin 2002-06-04 09:03:03 UTC 
Editor options have been transferred to XML form.
Please, transfer your options to XML also in
accordance with:
http://editor.netbeans.org/doc/Proposals/XMLSettings/UsersView.html#install

[You can found more info in the editor module
sources (layer.xml). Other modules that already
transferred the options: properties, jsp ...]
affected
class:org.netbeans.modules.xml.text.TextEditModuleInstall
Comment 1 _ pkuzel 2002-06-26 22:43:57 UTC 
I like layer based registrations.
Unfortunately correct fix is blocked by issue 25207.

Mato could you look at it please.
Comment 2 _ lkramolis 2002-07-17 14:58:59 UTC 
*** Issue 25126 has been marked as a duplicate of this issue. ***
Comment 3 _ lkramolis 2002-07-17 15:07:28 UTC 
* Synchronized abbreviation list representations in java
(text/syntax/XMLSettingsInitializer.java) with XML versions
(text/resources/XMLEditor-abbreviations.xml,
text/resources/DTDEditor-abbreviations.xml).

* Removed one obsolete XML macro.

[Fixed in main trunk.]
Comment 4 _ lkramolis 2002-07-17 15:09:31 UTC 
Petr, Martin, please, could review and test changes. Thanks.
Comment 5 _ lkramolis 2002-07-17 16:16:49 UTC 
Created attachment 6761 [details]
Proposed patch (against release34 branch).
Comment 6 _ pkuzel 2002-07-17 17:27:04 UTC 
Code Review:

I see it is moved to "declarative" registrations.
However addInitializer() in text-edit module installer retained. But is it an editor 
bug :-).

I agree with the patch because it also solves problems with abbreviations.
Comment 7 Jesse Glick 2002-07-17 20:02:19 UTC 
Could you please recheck the patch you attached here? It seems to have
a bit more stuff than just moving options registration. Removing
whitespace from an XML file? Various other whitespace changes? Light
gray to gray? A cleaner, trimmed patch would inspire more confidence
from reviewers that it is safe. If there are other changes you want to
make for 3.4, e.g. in abbreviations, they must be filed and announced
separately with separate justifications.
Comment 8 _ pkuzel 2002-07-17 23:02:38 UTC 
Sorry to confuse you.
Whitespace change, 
color change and map 
registrations changes 
all are necessary.

Reason is that all 
values are defined 
twice: once in Java and 
once in a XML file. 
Both must be present 
and values must match.
Comment 9 Martin Roskanin 2002-07-18 09:44:15 UTC 
Verified in the maintrunk build from 18.07.
The options are not loaded during the startup anymore. Thanks.
Comment 10 _ lkramolis 2002-07-18 17:21:49 UTC 
Fix also in release34 branch.
Comment 11 Martin Schovanek 2002-07-24 13:32:58 UTC 
VERIFIED
Comment 12 Quality Engineering 2003-07-02 08:39:24 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.