This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Inline field refactoring does not work as expected | ||
|---|---|---|---|
| Product: | java | Reporter: | Michel Graciano <hmichel> |
| Component: | Refactoring | Assignee: | Ralph Ruijs <ralphbenjamin> |
| Status: | REOPENED --- | ||
| Severity: | normal | CC: | ajeh, Chiana, misterm |
| Priority: | P3 | ||
| Version: | 7.2 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | 238595, 238598, 238614, 238658, 238717, 238720, 238948, 239000, 239005, 239161, 239187, 239191, 239211, 239337, 239397 | ||
| Bug Blocks: | |||
| Attachments: |
Info shown when getter/setter or comment exists
Info shown when getter/setter or comment exists |
||
|
Description
Michel Graciano
2012-07-03 17:48:54 UTC
Created attachment 121733 [details]
Info shown when getter/setter or comment exists
Creating a specific inline UI to specify whether or not rename getters/setters and comment occurrences seems to go against the idea of quick inline action. However, a simple yet practical solution seems to be as follows: after Ctrl-R when inline refactoring has started (all occurrences of the renamed entity emphasized and marked by rectangles), in case any relevant getters/setters or comments exist, show a passive info pop-up message as illustrated in attachment, and enable pressing Ctrl-R once more to open the existing refactoring dialog.
The info message should give accurate information, like if just a getter but no setter exist, reflect it in the message.
Alternatively to what I illustrate in the attachment, renaming getters/setters and occurrences in comments can be enabled by default and the message would just offer Ctrl-R to go to existing dialog only if users want to switch any of these options off. This might be probably the more practical option.
Created attachment 121734 [details]
Info shown when getter/setter or comment exists
As for exact wording if the alternative is accepted, I would consider: "dummy" getter, setter and instances in comments will be renamed. Press Ctrl-R for options. (In reply to comment #2) > Created attachment 121734 [details] > Info shown when getter/setter or comment exists I totally agree with this proposal. *** Bug 238207 has been marked as a duplicate of this bug. *** changeset : b43f743677af author : Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org> date : Tue Nov 19 15:35:14 CET 2013 summary : #215138 - Inline field refactoring does not work as expected After discussions with QA, the new instant refactoring is disabled by default and can be enabled by adding the startup-option -J-Dorg.netbeans.modules.java.refactoring.instantRename=true The instant refactoring will be enabled again after all issues have been fixed. http://hg.netbeans.org/jet-main/rev/d733d86ae410 from bug 239205, comment 1 + how to uncheck "Apply Rename on Comment" without mouse? Integrated into 'main-silver', will be available in build *201312130002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/d733d86ae410 User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org> Log: #215138 - InstantRename enabled by option org.netbeans.modules.java.refactoring.instantRename *** Bug 240453 has been marked as a duplicate of this bug. *** |