This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | CVS: Ask user for keyword substitution if file is not recognized. | ||
---|---|---|---|
Product: | obsolete | Reporter: | Jiri Kovalsky <jkovalsky> |
Component: | vcsgeneric | Assignee: | Martin Entlicher <mentlicher> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | Keywords: | UI |
Priority: | P1 | ||
Version: | 3.x | ||
Hardware: | PC | ||
OS: | Windows ME/2000 | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 35640, 41243, 51807 |
Description
Jiri Kovalsky
2002-03-12 09:31:16 UTC
I suggest to read first 1000 characters. If they are all > 30, consider it as text, if not, ask the user with a text like "This might be a binary file". What to do if there are more than one file selected? Should there be some table with file names and check-boxes for binary flag? Any other thoughts? UI keyword added. Target milestone was changed from not determined to TBD ...checking bugs and found out this: don't we have too many opened bugs for one thing? Please, see: issue #31056 issue #30112 I suggest to mark 2 of them as duplicats for one of those 3 Scheduling for promo-D. This didn't made it into promotion-D :-( The UI of Add command needs to be changed and it's too late to do this into 4.0 (it's after UI freeze). This needs to be resolved in the next release, scheduling for promo-E. Other IDEs use table here. It 4.1 timeframe I can implement simple chooser: o Autodetect (based on CVS repository setup) o Treat as binary (no textual diffs) o Treat as textual (harms binary files) The first option would be default because it works in most cases and covers well recursive structures too). Let me repeat that Martin's algorithm matched correct type in ~200 files I used for the testing. Please consider his work too. FIXED the chooser is implemented. Checking in vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/Bundle.properties; /cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/Bundle.properties,v <-- Bundle.properties new revision: 1.53; previous revision: 1.52 done Checking in vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvs.xml; /cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvs.xml,v <-- cvs.xml new revision: 1.112; previous revision: 1.111 done Verified. |