This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Provide an abstraction of ProcessBuilder in extexecution | ||
---|---|---|---|
Product: | platform | Reporter: | Petr Hejl <phejl> |
Component: | Execution | Assignee: | Petr Hejl <phejl> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | apireviews, jglick, jtulach |
Priority: | P3 | Keywords: | API, API_REVIEW_FAST |
Version: | 7.1 | ||
Hardware: | PC | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 199806 | ||
Attachments: |
the api change
updated patch Y01 fixed, more tests added |
Description
Petr Hejl
2011-11-14 15:23:02 UTC
Created attachment 113194 [details]
the api change
Please review. <issue number=""/> Created attachment 113198 [details]
updated patch
Fixed issue number. Thanks for catching.
Y01 I have a feeling ProcessBuilderFactory.Accessor is now visible in the API. It should rather be in a non-public package. Created attachment 113232 [details]
Y01 fixed, more tests added
Y01 fixed, more tests added
Thanks for the review. I'll integrate the change on Monday. The last patch applied as web-main 8b3129b61e9f. Petr, Jaroslav, It was planned to open NativeExecution API (well, that should be done long ago, actually... Still there is a desire to do so). I agree that it would good to have a single ProcessBuilder API. And I agree to try to use one from extexecution. But looks like proposed API misses some things needed for remote.. Could we think in the direction of merging what we have in RemoteProcessBuilder with what you have here? (In reply to comment #9) > I agree that it would good to have a single ProcessBuilder API. And I agree to > try to use one from extexecution. But looks like proposed API misses some > things needed for remote.. Would be good to know that things. I would suggest new issue with a problem description and patch. It is always easier to discuss a patch. > Could we think in the direction of merging what we > have in RemoteProcessBuilder with what you have here? I didn't find RemoteProcessBuilder anywhere. > I didn't find RemoteProcessBuilder anywhere.
Sorry - NativeProcessBuilder: dlight.nativeexecution/src/org/netbeans/modules/nativeexecution/api/NativeProcessBuilder.java
Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/8b3129b61e9f User: Petr Hejl <phejl@netbeans.org> Log: #205104 Provide an abstraction of ProcessBuilder in extexecution |