This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 205104 - Provide an abstraction of ProcessBuilder in extexecution
Summary: Provide an abstraction of ProcessBuilder in extexecution
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Execution (show other bugs)
Version: 7.1
Hardware: PC All
: P3 normal (vote)
Assignee: Petr Hejl
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks: 199806
  Show dependency tree
 
Reported: 2011-11-14 15:23 UTC by Petr Hejl
Modified: 2011-11-22 15:51 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
the api change (35.91 KB, patch)
2011-11-14 15:25 UTC, Petr Hejl 		Details | Diff
updated patch (35.92 KB, patch)
2011-11-14 18:08 UTC, Petr Hejl 		Details | Diff
Y01 fixed, more tests added (42.85 KB, patch)
2011-11-15 16:02 UTC, Petr Hejl 		Details | Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Hejl 2011-11-14 15:23:02 UTC 
As reported by Jarda, it would be beneficial to have an API/SPI abstraction of process builder. This API/SPI would hide the actual destination of process execution.
Comment 1 Petr Hejl 2011-11-14 15:25:29 UTC 
Created attachment 113194 [details]
the api change
Comment 2 Petr Hejl 2011-11-14 15:26:57 UTC 
Please review.
Comment 3 Jesse Glick 2011-11-14 16:22:48 UTC 
<issue number=""/>
Comment 4 Petr Hejl 2011-11-14 18:08:01 UTC 
Created attachment 113198 [details]
updated patch

Fixed issue number. Thanks for catching.
Comment 5 Jaroslav Tulach 2011-11-15 08:33:16 UTC 
Y01 I have a feeling ProcessBuilderFactory.Accessor is now visible in the API. It should rather be in a non-public package.
Comment 6 Petr Hejl 2011-11-15 16:02:01 UTC 
Created attachment 113232 [details]
Y01 fixed, more tests added

Y01 fixed, more tests added
Comment 7 Petr Hejl 2011-11-18 13:55:16 UTC 
Thanks for the review. I'll integrate the change on Monday.
Comment 8 Petr Hejl 2011-11-21 10:18:43 UTC 
The last patch applied as web-main 8b3129b61e9f.
Comment 9 Andrew Krasny 2011-11-21 10:50:43 UTC 
Petr, Jaroslav,


It was planned to open NativeExecution API (well, that should be done long ago, actually... Still there is a desire to do so).

I agree that it would good to have a single ProcessBuilder API. And I agree to try to use one from extexecution. But looks like proposed API misses some things needed for remote.. Could we think in the direction of merging what we have in RemoteProcessBuilder with what you have here?
Comment 10 Petr Hejl 2011-11-21 11:15:44 UTC 
(In reply to comment #9)
> I agree that it would good to have a single ProcessBuilder API. And I agree to
> try to use one from extexecution. But looks like proposed API misses some
> things needed for remote..
Would be good to know that things. I would suggest new issue with a problem description and patch. It is always easier to discuss a patch.

> Could we think in the direction of merging what we
> have in RemoteProcessBuilder with what you have here?
I didn't find RemoteProcessBuilder anywhere.
Comment 11 Andrew Krasny 2011-11-21 13:09:36 UTC 
> I didn't find RemoteProcessBuilder anywhere.
Sorry - NativeProcessBuilder: dlight.nativeexecution/src/org/netbeans/modules/nativeexecution/api/NativeProcessBuilder.java
Comment 12 Quality Engineering 2011-11-22 15:51:35 UTC 
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/8b3129b61e9f
User: Petr Hejl <phejl@netbeans.org>
Log: #205104 Provide an abstraction of ProcessBuilder in extexecution