This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Broken Code semantic completion for background property with multiple values | ||
|---|---|---|---|
| Product: | web | Reporter: | Vladimir Riha <vriha> |
| Component: | CSS Visual Tools | Assignee: | Marek Fukala <mfukala> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | mfukala, mmirilovic, pjiricka, vriha |
| Priority: | P1 | ||
| Version: | 7.1 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Issue Type: | DEFECT | Exception Reporter: | |
*** Bug 203064 has been marked as a duplicate of this bug. *** changeset: 207506:6d47f0669a2c date: Mon Nov 28 16:48:01 2011 +0100 summary: #203568 - complete grammar resolver and alternatives analyzer rewrite, implemented aggregation of properties with same name, fixed many bugs and typos in the properties definition files (though it is very likely there are more), disabled an obsolete module, added plenty of unit tests. There are still some known problems with the resolved/analyzer though they seem to be minor. Performance is worser than in the previous implementation - mainly due to the parsing mechanism of ambiguous grammars. There's a plenty of room for performance optimalizations though. Now the question is if the QE wants the fix in the 7.1. Even if there's lots of tests on almost everything affected still the change is quite huge and may possibly introduce some regressions. If it was up to me, I'd disable the css values error checks in 7.1 (so we at least do not bother users with false errors) and leave the completion untouched. Then in 7.1.1 I'll integrate this fix with some improvements after some more thorough QE verification. What do you think? Vlado? Mariane? Petre? My personal opinion : looking at the changeset http://hg.netbeans.org/web-main/rev/6d47f0669a2c it's huge and I do not want to do that during HR What we can do, is to integrate it into trunk, test it properly and fix in patch 1 for 7.1 I agree, this can wait to 7.1.1 > If it was up to me, I'd disable the css values error checks in 7.1 (so we at
> least do not bother users with false errors) and leave the completion untouched.
Sounds good.
Vlado, can you assess the current 7.1 situation in the css property values checking on some real word cases and let me know whether you consider it as so broken so it should be disabled or you do feel we can keep it and fix properly in 7.1.1?? Thank you in advance. I've tried some css files with css3 features and it shows some errors and a lot of "unexpected value token..." warnings so I guess it should be disabled for 7.1. Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/6d47f0669a2c User: Marek Fukala <mfukala@netbeans.org> Log: #203568 - complete grammar resolver and alternatives analyzer rewrite, implemented aggregation of properties with same name, fixed many bugs and typos in the properties definition files (though it is very likely there are more), disabled an obsolete module, added plenty of unit tests. There are still some known problems with the resolved/analyzer though they seem to be minor. Performance is worser than in the previous implementation - mainly due to the parsing mechanism of ambiguous grammars. There's a plenty of room for performance optimalizations though. So I'm going to disable the CSS property values error checks in release71 branch... 7.1 fix => P1 Ok, integrate into release71 ASAP please changeset: 214691:3b976b6dcd62 branch: release71 summary: #203568 - disabling css property values error checks in netbeans 7.1 http://hg.netbeans.org/releases/rev/3b976b6dcd62 Upon an agreement with Marian I've created new Bug 205843 so we can track the proper fix integration into 7.1.1 release Integrated into 'releases' Changeset: http://hg.netbeans.org/releases/rev/3b976b6dcd62 User: Marek Fukala <mfukala@netbeans.org> Log: #203568 - disabling css property values error checks in netbeans 7.1 verified initial problem in bug's description. More comments in issue #205843 Product Version: NetBeans IDE Dev (Build 201201010601) |
Steps to reproduce: - in css file, paste following: div{ background: #ff6666 } - type space after the color definition and invoke cc => nothing is offered and "," is autocompleted Also: - paste div{ background: center } - again type space after center and invoke cc => items only from background-position are offered (so no color, image etc. and also it completes already used properties/values). Product Version: NetBeans IDE Dev (Build 201110110600) Java: 1.7.0_01; Java HotSpot(TM) Client VM 21.1-b02 System: Windows XP version 5.1 running on x86; Cp1252; en_US (nb)