This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | NetBeans 7.0 presents itself as 6.9+ to VisualVM | ||
---|---|---|---|
Product: | platform | Reporter: | Jiri Kovalsky <jkovalsky> |
Component: | -- Other -- | Assignee: | Antonin Nebuzelsky <anebuzelsky> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | anebuzelsky, apireviews, jglick, jtulach, oaspublic, stefan79, thurka |
Priority: | P3 | Keywords: | API_REVIEW_FAST |
Version: | 7.0 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Attachments: |
Screenshot of incorrectly identified NetBeans IDE 7.0 application in VisualVM 1.3.2.
Proposed patch A patch for new "netbeans.productversion" property. |
*** Bug 197940 has been marked as a duplicate of this bug. *** I plan to add system property, which identified NetBeans version. This property will also allow us to display (in VisualVM) the correct name of every application build on top of NetBeans Platform. Created attachment 107980 [details]
Proposed patch
Proposed patch which will add netbeans.version system property.
Jardo, Jesse what do you think about proposed patch? Would choose a property name that more clearly indicates that this is an informational label, e.g. "netbeans.displayVersion". How is VisualVM using this information, anyway? Is it just calling com.sun.tools.attach.VirtualMachine.getSystemProperties? (In reply to comment #5) > Would choose a property name that more clearly indicates that this is an > informational label, e.g. "netbeans.displayVersion". OK. I don't care about name. > How is VisualVM using this information, anyway? Is it just calling > com.sun.tools.attach.VirtualMachine.getSystemProperties? VisualVM will read this system property and use its value as display name of monitored application. BTW: There are others way how to get system properties like using JMX or Serviceability Agent. Y01 Tomáš Hůrka told me he needs to brand the name three times in VisualVM and promised to provide a patch that eliminates that YO2 Missing changes to arch.xml and spec version update, and change to apichanges.xml YO3 Missing test Created attachment 110362 [details]
A patch for new "netbeans.productversion" property.
How about calling the property "netbeans.productversion". It contains the text displayed to the user as Product Version so this property name should match the expectations.
Please, review the attached patch (incl. an api change description and a test).
I would like to integrate very soon.
Seems harmless. Probably not useful for anything other than VisualVM, which specifically is restricted to inspecting runtime system properties. (For apisupport.ant it is necessary to identify a target VM on disk, which involves a different code path.) Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/11480ff5b39c User: Antonin Nebuzelsky <anebuzelsky@netbeans.org> Log: #197900: introducing "netbeans.productversion" property. *** Bug 201866 has been marked as a duplicate of this bug. *** |
Created attachment 107859 [details] Screenshot of incorrectly identified NetBeans IDE 7.0 application in VisualVM 1.3.2. Product Version: NetBeans IDE 7.0 (Build 201104080000) Java: 1.6.0_25; Java HotSpot(TM) Client VM 20.0-b11 System: Linux version 2.6.35-22-generic running on i386; UTF-8; cs_CZ (nb) Userdir: /home/cesilko/.netbeans/7.0 My NetBeans IDE 7.0 slowed down seriously while editing some HTML file so I wanted to generate a full thread dump using Visual VM 1.3.2. I was looking for NetBeans 7.0 node but didn't find it. I looked again and found NetBeans 6.9+ node instead. Can this be updated? See attached screenshot.