This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 197900 - NetBeans 7.0 presents itself as 6.9+ to VisualVM
Summary: NetBeans 7.0 presents itself as 6.9+ to VisualVM
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 7.0
Hardware: All All
: P3 normal (vote)
Assignee: Antonin Nebuzelsky
URL:
Keywords: API_REVIEW_FAST
: 197940 201866 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-04-20 11:33 UTC by Jiri Kovalsky
Modified: 2011-09-09 09:00 UTC (History)
7 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
Screenshot of incorrectly identified NetBeans IDE 7.0 application in VisualVM 1.3.2. (287.45 KB, image/png)
2011-04-20 11:33 UTC, Jiri Kovalsky
Details
Proposed patch (797 bytes, application/octet-stream)
2011-04-27 16:49 UTC, Tomas Hurka
Details
A patch for new "netbeans.productversion" property. (5.61 KB, patch)
2011-09-02 14:26 UTC, Antonin Nebuzelsky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Kovalsky 2011-04-20 11:33:12 UTC
Created attachment 107859 [details]
Screenshot of incorrectly identified NetBeans IDE 7.0 application in VisualVM 1.3.2.

Product Version: NetBeans IDE 7.0 (Build 201104080000)
Java: 1.6.0_25; Java HotSpot(TM) Client VM 20.0-b11
System: Linux version 2.6.35-22-generic running on i386; UTF-8; cs_CZ (nb)
Userdir: /home/cesilko/.netbeans/7.0

My NetBeans IDE 7.0 slowed down seriously while editing some HTML file so I wanted to generate a full thread dump using Visual VM 1.3.2. I was looking for NetBeans 7.0 node but didn't find it. I looked again and found NetBeans 6.9+ node instead. Can this be updated? See attached screenshot.
Comment 1 Tomas Hurka 2011-04-22 06:39:26 UTC
*** Bug 197940 has been marked as a duplicate of this bug. ***
Comment 2 Tomas Hurka 2011-04-22 06:42:06 UTC
I plan to add system property, which identified NetBeans version. This property will also allow us to display (in VisualVM) the correct name of every application build on top of NetBeans Platform.
Comment 3 Tomas Hurka 2011-04-27 16:49:51 UTC
Created attachment 107980 [details]
Proposed patch

Proposed patch which will add netbeans.version system property.
Comment 4 Tomas Hurka 2011-04-28 07:43:35 UTC
Jardo, Jesse what do you think about proposed patch?
Comment 5 Jesse Glick 2011-05-02 13:20:42 UTC
Would choose a property name that more clearly indicates that this is an informational label, e.g. "netbeans.displayVersion".

How is VisualVM using this information, anyway? Is it just calling com.sun.tools.attach.VirtualMachine.getSystemProperties?
Comment 6 Tomas Hurka 2011-05-02 14:03:20 UTC
(In reply to comment #5)
> Would choose a property name that more clearly indicates that this is an
> informational label, e.g. "netbeans.displayVersion".
OK. I don't care about name.

> How is VisualVM using this information, anyway? Is it just calling
> com.sun.tools.attach.VirtualMachine.getSystemProperties?
VisualVM will read this system property and use its value as display name of monitored application. BTW: There are others way how to get system properties like using JMX or Serviceability Agent.
Comment 7 Jaroslav Tulach 2011-05-04 07:37:49 UTC
Y01 Tomáš Hůrka told me he needs to brand the name three times in VisualVM and promised to provide a patch that eliminates that

YO2 Missing changes to arch.xml and spec version update, and change to apichanges.xml

YO3 Missing test
Comment 8 Antonin Nebuzelsky 2011-09-02 14:26:43 UTC
Created attachment 110362 [details]
A patch for new "netbeans.productversion" property.

How about calling the property "netbeans.productversion". It contains the text displayed to the user as Product Version so this property name should match the expectations.

Please, review the attached patch (incl. an api change description and a test).

I would like to integrate very soon.
Comment 9 Jesse Glick 2011-09-02 14:39:08 UTC
Seems harmless. Probably not useful for anything other than VisualVM, which specifically is restricted to inspecting runtime system properties. (For apisupport.ant it is necessary to identify a target VM on disk, which involves a different code path.)
Comment 10 Antonin Nebuzelsky 2011-09-05 08:52:51 UTC
http://hg.netbeans.org/core-main/rev/11480ff5b39c
Comment 11 Quality Engineering 2011-09-06 14:26:07 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/11480ff5b39c
User: Antonin Nebuzelsky <anebuzelsky@netbeans.org>
Log: #197900: introducing "netbeans.productversion" property.
Comment 12 Petr Cyhelsky 2011-09-09 09:00:07 UTC
*** Bug 201866 has been marked as a duplicate of this bug. ***