This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 179406

Summary:	82s in Add to Favorites action
Product:	platform	Reporter:	Exceptions Reporter <exceptions_reporter>
Component:	Favorites	Assignee:	Ondrej Vrabec <ovrabec>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dnikitin, emiddio, jtulach
Priority:	P3	Keywords:	PERFORMANCE
Version:	6.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:	161636
Attachments:	nps snapshot nps snapshot nps snapshot

Description Exceptions Reporter 2010-01-12 02:46:21 UTC

Build: NetBeans IDE 6.8 (Build 200912041610)
VM: Java HotSpot(TM) Client VM, 14.0-b16, Java(TM) SE Runtime Environment, 1.6.0_14-b08
OS: Windows Vista, 6.0, x86

User Comments:
GUEST: Right clicked an item in files pane.


Maximum slowness yet reported was 82549 ms, average is 51690

Comment 1 Exceptions Reporter 2010-01-12 02:46:28 UTC

Created attachment 93211 [details]
nps snapshot

Comment 2 emiddio 2010-01-15 02:45:23 UTC

Created attachment 93306 [details]
nps snapshot

Comment 3 emiddio 2010-01-17 16:34:03 UTC

Created attachment 93359 [details]
nps snapshot

Comment 4 Jaroslav Tulach 2010-01-18 09:25:37 UTC

isEnabled() test of Add To Favorites action is slow.

Comment 5 Jaroslav Tulach 2010-01-18 09:26:55 UTC

I suggest to leave the action enabled all the time and warn the user only if it is invoked. Also making the action asynchronous would be good idea.

Comment 6 Jaroslav Tulach 2010-01-18 09:37:20 UTC

core-main#d25c5c58dbf7 - review welcomed.

Comment 7 Quality Engineering 2010-01-18 23:35:07 UTC

Integrated into 'main-golden', will be available in build *201001190201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/d25c5c58dbf7
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #179406: Turning Add/Remove to/from Favorites into always enabled actions to save up to 80s

Comment 8 Jaroslav Tulach 2010-02-04 02:28:32 UTC

*** Bug 180236 has been marked as a duplicate of this bug. ***

Comment 9 Jaroslav Tulach 2010-02-12 12:28:33 UTC

*** Bug 180571 has been marked as a duplicate of this bug. ***

Comment 10 emiddio 2010-02-12 13:15:48 UTC

i run dev builds --dnload new devbuilds 2 times per wk average;

its still present in my latest dev build 201002110200

which is yesterdays build.

Comment 11 Ondrej Vrabec 2010-10-12 10:18:49 UTC

fix: http://hg.netbeans.org/cdev/rev/dec85c06f36e