This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | JavaFXDataSupport class needs to be exposed in public API to allow extending JavaFXDataObject | ||
---|---|---|---|
Product: | javafx | Reporter: | David Kaspar <dkaspar> |
Component: | Editor | Assignee: | Petr Suchomel <psuchomel> |
Status: | VERIFIED FIXED | ||
Severity: | normal | ||
Priority: | P1 | ||
Version: | 6.x | ||
Hardware: | PC | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
Proposed patch
Impoved patch Fixed patch |
Description
David Kaspar
2009-11-19 09:47:38 UTC
Created attachment 91367 [details]
Proposed patch
Created attachment 91370 [details]
Impoved patch
Attaching a new patch. The patch also contains a "position" attribute on "Loaders/text/x-fx/Factories/org-netbeans-modules-javafx-dataloader-JavaFXDataLoader.instance" file in layer.xml.
This is required for a custom DataLoader (which uses/derives from the text/x-fc) to specify the order of factories. Otherwise the custom DataLoader would have to use relative-positioning which is deprecated now.
Please clean up the Javadoc (author Jana Pokorsky?, java should be javafx, ...). Add @since, apichanges, etc. What is the use case of this API? Created attachment 91397 [details]
Fixed patch
Attaching a new patch.
The patch has the JavaDoc fixed (sorry for it, it was created in hurry) as well as the correct name of the createJavaFXFileEntry method.
The patch also does not have "JavaFXDataSupport.createJavaFXDataNode" method - it was there just to follow the same style as it is in the API of the "java.source" module - so I thought it will be a useful method in the future.
The patch still contains the "position" attribute for the "factory" of "text/x-fx" mimetype.
Integrated as changesets: http://hg.netbeans.org/javafx/rev/1a53fefe02d4 http://hg.netbeans.org/javafx/rev/20183f3f3a37 verified in RC1 candidate 200911252200 |