This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 177224 - JavaFXDataSupport class needs to be exposed in public API to allow extending JavaFXDataObject
Summary: JavaFXDataSupport class needs to be exposed in public API to allow extending ...
Status: VERIFIED FIXED
Alias: None
Product: javafx
Classification: Unclassified
Component: Editor (show other bugs)
Version: 6.x
Hardware: PC All
: P1 normal (vote)
Assignee: Petr Suchomel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-19 09:47 UTC by David Kaspar
Modified: 2009-11-26 06:19 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Proposed patch (5.38 KB, patch)
2009-11-19 09:48 UTC, David Kaspar 		Details | Diff
Impoved patch (6.07 KB, patch)
2009-11-19 10:28 UTC, David Kaspar 		Details | Diff
Fixed patch (5.25 KB, patch)
2009-11-20 02:01 UTC, David Kaspar 		Details | Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kaspar 2009-11-19 09:47:38 UTC 
JavaFX Composer plugin needs to expose JavaFXDataSupport class in public-packages. This is necessary for DataLoader of the Composer plugin to use the same FileEntry as the JavaFX cluster.

In the attachment there is a patch "javafxdatasupport.patch" for javafx.editor module. The patch just copies the JavaFXDataSupport class into a new public-API package "org.netbeans.api.javafx.dataloader". The class is copied because of preventing a possible break of other functionality since the class methods are used in the module itself.

This issue has been already discussed with and approved by QA. Therefore marking with "68_HR_FIX_CANDIDATE" keyword.
Comment 1 David Kaspar 2009-11-19 09:48:21 UTC 
Created attachment 91367 [details]
Proposed patch
Comment 2 David Kaspar 2009-11-19 10:28:27 UTC 
Created attachment 91370 [details]
Impoved patch

Attaching a new patch. The patch also contains a "position" attribute on "Loaders/text/x-fx/Factories/org-netbeans-modules-javafx-dataloader-JavaFXDataLoader.instance" file in layer.xml.
This is required for a custom DataLoader (which uses/derives from the text/x-fc) to specify the order of factories. Otherwise the custom DataLoader would have to use relative-positioning which is deprecated now.
Comment 3 Tomas Zezula 2009-11-20 00:30:49 UTC 
Please clean up the Javadoc (author Jana Pokorsky?, java should be javafx, ...).
Add @since, apichanges, etc.
What is the use case of this API?
Comment 4 David Kaspar 2009-11-20 02:01:18 UTC 
Created attachment 91397 [details]
Fixed patch

Attaching a new patch.

The patch has the JavaDoc fixed (sorry for it, it was created in hurry) as well as the correct name of the createJavaFXFileEntry method.

The patch also does not have "JavaFXDataSupport.createJavaFXDataNode" method - it was there just to follow the same style as it is in the API of the "java.source" module - so I thought it will be a useful method in the future.

The patch still contains the "position" attribute for the "factory" of "text/x-fx" mimetype.
Comment 6 Lukas Hasik 2009-11-26 06:19:07 UTC 
verified in RC1 candidate 200911252200