This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Patch: Use JComboBox and JTextArea mixed together to improve license display | ||
---|---|---|---|
Product: | platform | Reporter: | johnsonlau <johnsonlau> |
Component: | Autoupdate | Assignee: | Jiri Rechtacek <jrechtacek> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | jeremie, jkovalsky, olangr |
Priority: | P3 | Keywords: | NETFIX, UI |
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Bug Depends on: | 200765 | ||
Bug Blocks: | |||
Attachments: |
License displayed in Eclipse
Improvement Preview patch of this improvement, waiting review reworked patch autoupdate screenshot (use combobox) Patch: Improved license display (against the latest main repo) |
Description
johnsonlau
2009-09-19 14:43:59 UTC
Created attachment 87951 [details]
License displayed in Eclipse
Created attachment 87952 [details]
Improvement Preview
Created attachment 90212 [details]
patch of this improvement, waiting review
The patch to this issue was attached. And default size of the window might need to be extended with more spaces for better reading experiences on the license text. I didn't know how to rearrage size on a window that autoupdate UI uses. Is there anyone who can help me with this? Thank you. Ondrej, what do you think on this? PS. Need to check with legal on this change, I`ll ask Jeremie. PPS. I personally don`t think that "version" is necessary in that table. As for license agreements, how many have you actually had read all the way through? :-) From my experience, vast majority of users do not read those, it's just another annoying screen to click next at. I agree with making clear there are licenses for individual items, but let's use some less heavy-weight UI .. ideally a short hyperlink contents at the beginning of the document or possibly a combo box for products above the license (hidden if there's just one product). So that the screen doesn't require much cognitive load and remains reasonably simple. Also, we wouldn't need a resize then .. John, what do you think about Ondrej's proposal to have a combobox with plugins to be installed above the license text area? BTW, I also agree that versioning information is not important here. Would you be willing to rework the patch? Thanks a lot John for your contribution! UI re-designed. Now a combo box is used instead to show a list of all plugins above the license text area. The license will be refreshed in 100ms when an combo item is selected. The delay is to prevent the content refresh going too soon to acknowledge the user that there has been a refresh already, especially when two licenses are exactly the same contents. Created attachment 91814 [details]
reworked patch
reworked patch using combo box
Could you please attach the screenshot which refers to this patch? Thanks in advance for your contributions! Created attachment 91822 [details]
autoupdate screenshot (use combobox)
Improved Autoupdate UI screenshot using combobox
I like the new patch. Dmitry, can you please review and integrate this finally? Thanks a lot! This issue is being tracked as NetFIXed RFE now. Thanks, looks fine to me. I`ll check with Legal whether is it acceptable from their perspective. Thank you for proposing this patch johnsonlau. Product and technology law department department will be looking at your the proposal. From my stand point, patch looks pretty good at the first glance; however I keep in mind that there might have been good reason why displaying all licenses at once. I found it always tricky to combine legal needs with high standard in user experience ;). More to come in coming days, stay tuned! Dmitry, did you have a chance to consult with legal about it? I can help if you want. Thanks! I can integrate the patch, but it is no longer applicable to recent version of the code. Can you bring it up-to-date with latest changes in the autoupdate.ui module? Zhongcheng, would it be possible to update your sources and generate the patch one more time? Thanks! Created attachment 102780 [details]
Patch: Improved license display (against the latest main repo)
The patch for the latest main repo.
Nothing important but only the plugin display output has been changed since last patch.
Now plugin name / version will be formatted as PLUGIN_NAME: [VERSION] instead of formely PLUGIN_NAME - VERSION.
The patch was applied in core-main/rev/f32a41be998c Thanks a lot for the contribution. |