Please use the Apache issue tracking system for new NetBeans issues ( !!
Bug 172599 - Patch: Use JComboBox and JTextArea mixed together to improve license display
Patch: Use JComboBox and JTextArea mixed together to improve license display
Product: platform
Classification: Unclassified
Component: Autoupdate
All All
: P3 (vote)
: 7.2
Assigned To: Jiri Rechtacek
Depends on: 200765
  Show dependency treegraph
Reported: 2009-09-19 14:43 UTC by johnsonlau
Modified: 2012-02-10 13:42 UTC (History)
3 users (show)

See Also:

License displayed in Eclipse (95.48 KB, image/png)
2009-09-19 14:44 UTC, johnsonlau
Improvement Preview (50.75 KB, image/png)
2009-09-19 14:45 UTC, johnsonlau
patch of this improvement, waiting review (21.80 KB, patch)
2009-10-29 15:40 UTC, johnsonlau
Details | Diff
reworked patch (20.67 KB, patch)
2009-11-28 10:54 UTC, johnsonlau
Details | Diff
autoupdate screenshot (use combobox) (46.26 KB, image/png)
2009-11-29 02:46 UTC, johnsonlau
Patch: Improved license display (against the latest main repo) (20.34 KB, patch)
2010-11-03 13:39 UTC, johnsonlau
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description johnsonlau 2009-09-19 14:43:59 UTC
Currently, autoudpate.ui plugin uses only a JTextArea to display all licenses.
It's diffcult to identify the licenses required by the extra plugin.

Eclipse uses a mixed table and text area to display licenses separately.
When user clicks on the plugin which is listed as a table item,
licenses to the plugin will be displayed in the text area.

I would like to change NetBeans' UI as the way Eclipse does.
See the attachment I posted for a preview.
Comment 1 johnsonlau 2009-09-19 14:44:50 UTC
Created attachment 87951 [details]
License displayed in Eclipse
Comment 2 johnsonlau 2009-09-19 14:45:29 UTC
Created attachment 87952 [details]
Improvement Preview
Comment 3 johnsonlau 2009-10-29 15:40:40 UTC
Created attachment 90212 [details]
patch of this improvement, waiting review
Comment 4 johnsonlau 2009-10-29 15:48:26 UTC
The patch to this issue was attached.

And default size of the window might need to
be extended with more spaces for better reading experiences on the license text.
I didn't know how to rearrage size on a window that autoupdate UI uses.
Is there anyone who can help me with this?
Thank you.
Comment 5 dlipin 2009-11-02 11:59:43 UTC
Ondrej, what do you think on this? 
PS. Need to check with legal on this change, I`ll ask Jeremie.
PPS. I personally don`t think that "version" is necessary in that table.
Comment 6 Ondrej Langr 2009-11-02 12:13:27 UTC
As for license agreements, how many have you actually had read all the way through? :-)

From my experience, vast majority of users do not read those, it's just another annoying screen to click next at. 

I agree with making clear there are licenses for individual items, but let's use some less heavy-weight UI .. ideally a
short hyperlink contents at the beginning of the document or possibly a combo box for products above the license (hidden
if there's just one product). So that the screen doesn't require much cognitive load and remains reasonably simple.
Also, we wouldn't need a resize then .. 
Comment 7 Jiri Kovalsky 2009-11-27 04:49:13 UTC
John, what do you think about Ondrej's proposal to have a combobox with plugins to be installed above the license text area? BTW, I also agree that versioning information is not important here. Would you be willing to rework the patch? 

Thanks a lot John for your contribution!
Comment 8 johnsonlau 2009-11-28 10:52:58 UTC
UI re-designed.
Now a combo box is used instead
to show a list of all plugins above the license text area.

The license will be refreshed in 100ms when an combo item is selected.
The delay is to prevent the content refresh going too soon to
acknowledge the user that there has been a refresh already,
especially when two licenses are exactly the same contents.
Comment 9 johnsonlau 2009-11-28 10:54:36 UTC
Created attachment 91814 [details]
reworked patch

reworked patch using combo box
Comment 10 dlipin 2009-11-29 02:31:28 UTC
Could you please attach the screenshot which refers to this patch? Thanks in advance for your contributions!
Comment 11 johnsonlau 2009-11-29 02:46:04 UTC
Created attachment 91822 [details]
autoupdate screenshot (use combobox)

Improved Autoupdate UI screenshot using combobox
Comment 12 Jiri Kovalsky 2009-12-02 15:07:16 UTC
I like the new patch. Dmitry, can you please review and integrate this finally? Thanks a lot!
Comment 13 Jiri Kovalsky 2009-12-03 15:25:03 UTC
This issue is being tracked as NetFIXed RFE now.
Comment 14 dlipin 2009-12-09 03:54:34 UTC
Thanks, looks fine to me. I`ll check with Legal whether is it acceptable from their perspective.
Comment 15 Jeremie Bertolino 2009-12-10 23:59:14 UTC
Thank you for proposing this patch johnsonlau.

Product and technology law department department will be looking at your the proposal. 

From my stand point, patch looks pretty good at the first glance; however I keep in mind that there might have been good reason why displaying all licenses at once. 

I found it always tricky to combine legal needs with high standard in user experience ;).

More to come in coming days, stay tuned!
Comment 16 Jiri Kovalsky 2010-04-08 12:08:05 UTC
Dmitry, did you have a chance to consult with legal about it? I can help if you want. Thanks!
Comment 17 Jaroslav Tulach 2010-11-01 09:29:03 UTC
I can integrate the patch, but it is no longer applicable to recent version of the code. Can you bring it up-to-date with latest changes in the autoupdate.ui module?
Comment 18 Jiri Kovalsky 2010-11-01 20:24:07 UTC
Zhongcheng, would it be possible to update your sources and generate the patch one more time? Thanks!
Comment 19 johnsonlau 2010-11-03 13:39:08 UTC
Created attachment 102780 [details]
Patch: Improved license display (against the latest main repo)

The patch for the latest main repo.

Nothing important but only the plugin display output has been changed since last patch.
Now plugin name / version will be formatted as PLUGIN_NAME: [VERSION] instead of formely PLUGIN_NAME - VERSION.
Comment 20 Jiri Rechtacek 2012-02-10 13:42:52 UTC
The patch was applied in core-main/rev/f32a41be998c
Thanks a lot for the contribution.

By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2014, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo