This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | org.netbeans.modules.web.core.syntax classes are loaded during NetBeans startup with LimeWire project | ||
---|---|---|---|
Product: | editor | Reporter: | Alexander Kouznetsov <mrkam> |
Component: | -- Other -- | Assignee: | issues@editor <issues> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | issues, jtulach, mfukala, pjiricka, vstejskal |
Priority: | P2 | Keywords: | PERFORMANCE, REGRESSION, TEST |
Version: | 6.x | ||
Hardware: | PC | ||
OS: | Windows XP | ||
URL: | http://wiki.netbeans.org/FitnessViaWhiteAndBlackList | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
Stacktraces
mbohm's call stack mbohm's call stack, hidden source calls expanded mbohm's call stack, hidden source calls expanded A patch that should remedy the problem Output from 'ant test' in ide.kit/test/whitelist |
Description
Alexander Kouznetsov
2008-12-23 19:12:43 UTC
Created attachment 75281 [details]
Stacktraces
If I get the timing right, I am able to attach a debugger to the IDE as it starts. I got a conditional breakpoint to catch at org.openide.loaders.InstanceSupport.findClass(InstanceSupport.java:495) with condition name.indexOf("EmbeddingProviderImpl") != -1. When it caught for me, the call stack was slightly different. (See callstack.gif attached.) The commonality starts at org.netbeans.modules.editor.impl.KitsTrackerImpl.updateAndGet(KitsTrackerImpl.java:452). Ultimately, it looks like the class is loaded due to the <file name="org-netbeans-modules-web-core-syntax-EmbeddingProviderImpl$Factory.instance" /> nested in Editors/text/x-jsp within web.core.syntax/src/org/netbeans/modules/web/core/syntax/resources/layer.xml. I'm not sure about the purpose of this layer entry, so I can't comment on whether it could potentially be removed. I'm also not familiar with the calling code (for either call stack), so I don't know whether it could be modified. Can anyone provide more details on the calling code (starting at KitsTrackerImpl.java:452) or the layer.xml entry? Created attachment 75802 [details]
mbohm's call stack
vstejskal, it looks like you wrote KitsTrackerImpl; can you advise? Created attachment 75803 [details]
mbohm's call stack, hidden source calls expanded
Created attachment 75804 [details]
mbohm's call stack, hidden source calls expanded
Marking TM != TBD. Created attachment 75976 [details]
A patch that should remedy the problem
Yeah, one day we may be able to delete KitsTrackerImpl, but until then we will have to deal with situations like this one. The attached patch should fix the problem. I'm not able to run the tests to see if it really does or not. Please apply the patch and let me know if it helped. If so, feel free to push the change. Thanks what is the status of this issue? could it be closed after Vita's patch? I can see following classes loaded in 20090608 org.netbeans.modules.web.core.syntax.EmbeddingProviderImpl$Factory org.netbeans.modules.web.core.syntax.gsf.JspEmbeddingProvider$Factory org.netbeans.modules.web.core.syntax.gsf.JspLanguage org.netbeans.modules.web.core.syntax.indent.ExpressionLanguageIndentTaskFactory Loading of org.netbeans.modules.web.core.syntax.gsf.JspLanguage is hopefully fixed by the fix of issue 161179. http://hg.netbeans.org/jet-main/rev/7ad5a2ca5c7c Still not able to run whitelist tests, followed instructions at the bottom of http://wiki.netbeans.org/FitnessViaWhiteAndBlackList and got an error, see attachment. Created attachment 87479 [details]
Output from 'ant test' in ide.kit/test/whitelist
Integrated into 'main-golden', will be available in build *200909131354* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/7ad5a2ca5c7c User: Vita Stejskal <vstejskal@netbeans.org> Log: #156018: first check .instance files that have "instanceOf" attribute, all EditorKit impls should have it |