This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 156018 - org.netbeans.modules.web.core.syntax classes are loaded during NetBeans startup with LimeWire project
Summary: org.netbeans.modules.web.core.syntax classes are loaded during NetBeans start...
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: PC Windows XP
: P2 blocker (vote)
Assignee: issues@editor
URL: http://wiki.netbeans.org/FitnessViaWh...
Keywords: PERFORMANCE, REGRESSION, TEST
Depends on:
Blocks:
 
Reported: 2008-12-23 19:12 UTC by Alexander Kouznetsov
Modified: 2009-09-13 21:03 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Stacktraces (13.01 KB, text/plain)
2008-12-23 19:13 UTC, Alexander Kouznetsov 		Details
mbohm's call stack (6.10 KB, image/gif)
2009-01-14 04:06 UTC, Matthew Bohm 		Details
mbohm's call stack, hidden source calls expanded (5.76 KB, image/gif)
2009-01-14 04:15 UTC, Matthew Bohm 		Details
mbohm's call stack, hidden source calls expanded (5.76 KB, image/gif)
2009-01-14 04:15 UTC, Matthew Bohm 		Details
A patch that should remedy the problem (1.09 KB, text/plain)
2009-01-19 10:48 UTC, Vitezslav Stejskal 		Details
Output from 'ant test' in ide.kit/test/whitelist (715 bytes, text/plain)
2009-09-11 07:56 UTC, Vitezslav Stejskal 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kouznetsov 2008-12-23 19:12:43 UTC 
Performance test reports there is a regression in NetBeans startup with LimeWire project which is caused by the loading
of the following classes:

org.netbeans.modules.web.core.syntax.EmbeddingProviderImpl$Factory
org.netbeans.modules.web.core.syntax.JSPParserFactory

Please don't load these classes unless they're really necessary.

Comment from jtulach: "Bug caused by usage of pre61settings.KeybindingsInjector.afterLoad."

More information about the test is available via the URL specified.
Comment 1 Alexander Kouznetsov 2008-12-23 19:13:15 UTC 
Created attachment 75281 [details]
Stacktraces
Comment 2 Matthew Bohm 2009-01-14 04:05:30 UTC 
If I get the timing right, I am able to attach a debugger to the IDE as it starts. I got a conditional breakpoint to
catch at org.openide.loaders.InstanceSupport.findClass(InstanceSupport.java:495) with condition
name.indexOf("EmbeddingProviderImpl") != -1. When it caught for me, the call stack was slightly different. (See
callstack.gif attached.) The commonality starts at
org.netbeans.modules.editor.impl.KitsTrackerImpl.updateAndGet(KitsTrackerImpl.java:452).

Ultimately, it looks like the class is loaded due to the <file
name="org-netbeans-modules-web-core-syntax-EmbeddingProviderImpl$Factory.instance" /> nested in Editors/text/x-jsp
within web.core.syntax/src/org/netbeans/modules/web/core/syntax/resources/layer.xml.

I'm not sure about the purpose of this layer entry, so I can't comment on whether it could potentially be removed. I'm
also not familiar with the calling code (for either call stack), so I don't know whether it could be modified. Can
anyone provide more details on the calling code (starting at KitsTrackerImpl.java:452) or the layer.xml entry?
Comment 3 Matthew Bohm 2009-01-14 04:06:22 UTC 
Created attachment 75802 [details]
mbohm's call stack
Comment 4 Matthew Bohm 2009-01-14 04:11:58 UTC 
vstejskal, it looks like you wrote KitsTrackerImpl; can you advise?
Comment 5 Matthew Bohm 2009-01-14 04:15:01 UTC 
Created attachment 75803 [details]
mbohm's call stack, hidden source calls expanded
Comment 6 Matthew Bohm 2009-01-14 04:15:39 UTC 
Created attachment 75804 [details]
mbohm's call stack, hidden source calls expanded
Comment 7 Matthew Bohm 2009-01-14 19:03:07 UTC 
Marking TM != TBD.
Comment 8 Vitezslav Stejskal 2009-01-19 10:48:21 UTC 
Created attachment 75976 [details]
A patch that should remedy the problem
Comment 9 Vitezslav Stejskal 2009-01-19 10:51:14 UTC 
Yeah, one day we may be able to delete KitsTrackerImpl, but until then we will have to deal with situations like this
one. The attached patch should fix the problem. I'm not able to run the tests to see if it really does or not. Please
apply the patch and let me know if it helped. If so, feel free to push the change. Thanks
Comment 10 Jindrich Sedek 2009-04-15 16:11:30 UTC 
what is the status of this issue? could it be closed after Vita's patch?
Comment 11 Oleg Khokhlov 2009-06-10 16:54:34 UTC 
I can see following classes loaded in 20090608
org.netbeans.modules.web.core.syntax.EmbeddingProviderImpl$Factory
org.netbeans.modules.web.core.syntax.gsf.JspEmbeddingProvider$Factory
org.netbeans.modules.web.core.syntax.gsf.JspLanguage
org.netbeans.modules.web.core.syntax.indent.ExpressionLanguageIndentTaskFactory
Comment 12 Petr Jiricka 2009-07-21 15:12:46 UTC 
Loading of org.netbeans.modules.web.core.syntax.gsf.JspLanguage is hopefully fixed by the fix of issue 161179.
Comment 13 Vitezslav Stejskal 2009-09-11 07:55:25 UTC 
http://hg.netbeans.org/jet-main/rev/7ad5a2ca5c7c

Still not able to run whitelist tests, followed instructions at the bottom of
http://wiki.netbeans.org/FitnessViaWhiteAndBlackList and got an error, see attachment.
Comment 14 Vitezslav Stejskal 2009-09-11 07:56:16 UTC 
Created attachment 87479 [details]
Output from 'ant test' in ide.kit/test/whitelist
Comment 15 Quality Engineering 2009-09-13 21:03:53 UTC 
Integrated into 'main-golden', will be available in build *200909131354* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/7ad5a2ca5c7c
User: Vita Stejskal <vstejskal@netbeans.org>
Log: #156018: first check .instance files that have "instanceOf" attribute, all EditorKit impls should have it