This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 124323

Summary:	Optimization to HgCommand.getSingleStatus
Product:	versioncontrol	Reporter:	Padraig Obriain <padraigob>
Component:	Mercurial	Assignee:	issues@versioncontrol <issues>
Status:	RESOLVED FIXED
Severity:	blocker
Priority:	P3
Version:	6.x
Hardware:	Sun
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Attachments:	proposed patch

Description Padraig Obriain 2007-12-20 14:05:11 UTC

In HgCommand.getSingleStatus there is a call to HgUtils.isIgnored. This occurs after a call to doSingleStatusCmd.

It looks to me that the call to HgUtils.isIgnored could be done before the call to doSingleStatusCnmd and so avoid the
exec call when HgUtils.isIgnored returns true.

Comment 1 Padraig Obriain 2008-01-08 16:21:06 UTC

Created attachment 54821 [details]
proposed patch

Comment 2 Padraig Obriain 2008-01-09 08:15:18 UTC

IDE:-------------------------------------------------
IDE: [1/9/08 8:12 AM] Committing "HgCommand.java" started
Checking in HgCommand.java;
/shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/util/HgCommand.java,v  <-- 
HgCommand.java
new revision: 1.64; previous revision: 1.63
done
IDE: [1/9/08 8:12 AM] Committing "HgCommand.java" finished
IDE: [1/9/08 8:12 AM] Diffing finished