This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 124323 - Optimization to HgCommand.getSingleStatus
Summary: Optimization to HgCommand.getSingleStatus
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 6.x
Hardware: Sun All
: P3 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-20 14:05 UTC by Padraig Obriain
Modified: 2008-01-09 08:15 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
proposed patch (1.72 KB, patch)
2008-01-08 16:21 UTC, Padraig Obriain
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Padraig Obriain 2007-12-20 14:05:11 UTC
In HgCommand.getSingleStatus there is a call to HgUtils.isIgnored. This occurs after a call to doSingleStatusCmd.

It looks to me that the call to HgUtils.isIgnored could be done before the call to doSingleStatusCnmd and so avoid the
exec call when HgUtils.isIgnored returns true.
Comment 1 Padraig Obriain 2008-01-08 16:21:06 UTC
Created attachment 54821 [details]
proposed patch
Comment 2 Padraig Obriain 2008-01-09 08:15:18 UTC
IDE:-------------------------------------------------
IDE: [1/9/08 8:12 AM] Committing "HgCommand.java" started
Checking in HgCommand.java;
/shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/util/HgCommand.java,v  <-- 
HgCommand.java
new revision: 1.64; previous revision: 1.63
done
IDE: [1/9/08 8:12 AM] Committing "HgCommand.java" finished
IDE: [1/9/08 8:12 AM] Diffing finished