This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 231818 - AssertionError at org.netbeans.modules.progress.ui.RunOffEDTImpl.createModalDialog
Summary: AssertionError at org.netbeans.modules.progress.ui.RunOffEDTImpl.createModalD...
Status: RESOLVED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Project (show other bugs)
Version: 7.4
Hardware: All All
: P3 normal (vote)
Assignee: Milos Kleint
URL:
Keywords:
: 231933 231950 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-06-26 08:44 UTC by Alexander Simon
Modified: 2013-07-01 08:36 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter: 201697

Attachments
stacktrace (4.30 KB, text/plain)
2013-06-26 08:44 UTC, Alexander Simon 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Simon 2013-06-26 08:44:24 UTC 
Build: NetBeans IDE Dev (Build 20130626-8093670afabf)
VM: Java HotSpot(TM) Client VM, 23.21-b01, Java(TM) SE Runtime Environment, 1.7.0_21-b11
OS: SunOS

User Comments:
alexvsimon: compile file




Stacktrace: 
java.lang.AssertionError
   at org.netbeans.modules.progress.ui.RunOffEDTImpl.createModalDialog(RunOffEDTImpl.java:557)
   at org.netbeans.modules.progress.ui.RunOffEDTImpl.runOffEventThreadCustomDialogImpl(RunOffEDTImpl.java:241)
   at org.netbeans.modules.progress.ui.RunOffEDTImpl.runOffEventThreadWithCustomDialogContent(RunOffEDTImpl.java:222)
   at org.netbeans.api.progress.ProgressUtils.runOffEventThreadWithCustomDialogContent(ProgressUtils.java:214)
   at org.netbeans.modules.cnd.utils.ui.ModalMessageDlg.run(ModalMessageDlg.java:136)
   at org.netbeans.modules.cnd.utils.ui.ModalMessageDlg.runLongTask(ModalMessageDlg.java:102)
Comment 1 Alexander Simon 2013-06-26 08:44:27 UTC 
Created attachment 136315 [details]
stacktrace
Comment 2 Andrew Krasny 2013-06-26 12:00:40 UTC 
The change that caused the regression is:

257205:f2927475bfa1 - mkleint Jun 24, 2013
#180542, #188382, #213607, #177959 actionPerformed() in lookupSensitiveAction subclasses posted to RP. In tests kept in AWT to avoid deleting them altogether. Might have problems primarily with lookup content changing between AWT and RP processing.
Comment 3 Milos Kleint 2013-06-26 14:21:27 UTC 
The API contract for ActionProvider never states that it's methods will be called exclusively from AWT.
Comment 4 Andrew Krasny 2013-06-26 14:23:33 UTC 
(In reply to comment #3)
> The API contract for ActionProvider never states that it's methods will be
> called exclusively from AWT.

This is no true. Please refer to the javadoc:

public interface ActionProvider {
...
    /**
     * Run a project command.
     * Will be invoked in the event thread.
...
     * @see ActionProgress
     */
    void invokeAction(String command, Lookup context) throws IllegalArgumentException;
...
}
Comment 5 Milos Kleint 2013-06-26 14:25:22 UTC 
(In reply to comment #3)
> The API contract for ActionProvider never states that it's methods will be
> called exclusively from AWT.

Sorry, the invokeAction() does state that it's called in AWT. The other methods don't. I believe the contract has to go, even getting Projects out of the action context is slow.
Comment 6 Milos Kleint 2013-06-26 14:26:03 UTC 
how hard is to change your code?
Comment 7 Milos Kleint 2013-06-26 16:06:33 UTC 
http://hg.netbeans.org/core-main/rev/c7fda4b8c08e
Comment 8 Tomas Zezula 2013-06-27 16:13:40 UTC 
*** Bug 231933 has been marked as a duplicate of this bug. ***
Comment 9 Quality Engineering 2013-06-28 02:17:52 UTC 
Integrated into 'main-silver', will be available in build *201306272300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/c7fda4b8c08e
User: Milos Kleint <mkleint@netbeans.org>
Log: #231818 ActionProvider's javadoc states the perform() method is to be called in AWT.
Comment 10 Tomas Zezula 2013-07-01 08:36:25 UTC 
*** Bug 231950 has been marked as a duplicate of this bug. ***