This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Created attachment 133872 [details] shows the issue ACTUAL Clash of mnemonics: "&Create" vs. "&Checkout..." EXPECTED no clash FYI: was introduced by http://hg.netbeans.org/core-main/rev/d5e0b056150
Other subtle issues/inconsistences in the dialog: * Why there are mnemonics for "Commit &ID", "&Author", "&Message"? The user can press the mnemonics, but the fields next to the labels are always disabled/readonly. So I propose to remove the mnemonics * some labels end with a colon - some not * some labels are not aligned
Created attachment 133874 [details] Proposed patch I like to propose the following patch to solve the described issues. * Updated mnemonics * Removed mnemonics for labels, which are linked to readonly/disabled controls * Some minor layout modifications, so it looks cleaner Please have a look.
Created attachment 133875 [details] Patch in action
(In reply to comment #1) > * Why there are mnemonics for "Commit &ID", "&Author", "&Message"? The user can > press the mnemonics, but the fields next to the labels are always > disabled/readonly. So I propose to remove the mnemonics I looked it up. The issue also applies to HG implementation. Should I file a separate issue for this?
(In reply to comment #1) > * Why there are mnemonics for "Commit &ID", "&Author", "&Message"? The user can > press the mnemonics, but the fields next to the labels are always > disabled/readonly. So I propose to remove the mnemonics Well, they're control fields so i assumed they should have a mnemonic. User can navigate via keyboard and still with keyboard for example select and copy the field's value. I have no idea if A11Y specs says anything about this, do you? In order to avoid any accessibility issues, i would rather keep the mnemonics. Any idea?
(In reply to comment #5) > (In reply to comment #1) > > * Why there are mnemonics for "Commit &ID", "&Author", "&Message"? The user can > > press the mnemonics, but the fields next to the labels are always > > disabled/readonly. So I propose to remove the mnemonics > Well, they're control fields so i assumed they should have a mnemonic. User can > navigate via keyboard and still with keyboard for example select and copy the > field's value. You are right. I wasn't aware that you still can select the content in readonly controls. I will update the patch.
Created attachment 133897 [details] Proposed patch v2 Here the patch without the removal of mnemonics of the readonly control's labels
thanks for the patch, pushed as http://hg.netbeans.org/core-main/rev/d7cf7ee1b780
Integrated into 'main-golden', will be available in build *201305021042* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/d7cf7ee1b780 User: Benno Markiewicz <markiewb@netbeans.org> Log: #229106 - Create branch dialog: clash of mnemonics and other usability issues
Verified in 201307222300