This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 98197

Summary:	Implementation of FileEncodingQuery is slow
Product:	projects	Reporter:	_ rkubacki <rkubacki>
Component:	Generic Infrastructure	Assignee:	Jaroslav Tulach <jtulach>
Status:	VERIFIED FIXED
Severity:	blocker	CC:	issues, jtulach, tzezula
Priority:	P3	Keywords:	PERFORMANCE
Version:	6.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:	147492
Bug Blocks:	42638, 62707

Description _ rkubacki 2007-03-19 14:00:35 UTC

because current impl is DataObjectEncodingQueryImplementation that goes through
getLookup() to find impl. This means that we need to get node of DO before we
get encoding in most of cases. This is probably a big problem if we want to use
this in searches and similar acivities.

Comment 1 Milos Kleint 2007-03-19 14:05:56 UTC

-> tzezula

Comment 2 Jesse Glick 2007-03-21 02:18:47 UTC

It only goes through DataNode if DataObject.getLookup is not overridden. The
default impl is not just slow, it is quite deadlock-prone, especially in
combination with FEQ (as I have found the hard way); every DO subclass in the
IDE should be fixed to override getLookup, I think. I already fixed
AntProjectDataObject after getting a couple of deadlocks. apisupport overrides
it for newly created DO subclasses. I would suggest that the default impl log a
warning (once per subclass) to remind people about it.

Comment 3 Lukas Hasik 2008-04-10 21:41:33 UTC

moving opened issues from TM <= 6.1 to TM=Dev

Comment 4 Tomas Danek 2008-09-09 15:09:55 UTC

still TM=6.5?

Comment 5 Jan Lahoda 2008-09-09 15:16:20 UTC

If I understand everything correctly, if all DOs would override getLookup reasonably, all should be OK. In issue #146377
Jarda wrote:
"we shall fix all data objects we have under our control, e.g. in the NetBeans IDE" (we shall fix all DOs to override
getLookup reasonably).

Jarda, please make sure this happens. Thanks.

Comment 6 Tomas Zezula 2008-09-09 15:18:47 UTC

>If I understand everything correctly, if all DOs would override getLookup reasonably, all should be OK.
Right

Comment 7 Tomas Zezula 2008-09-09 15:22:44 UTC

Anyway Jarda is an owner of FEQ from the NB 6.1

Comment 8 Jaroslav Tulach 2008-09-24 12:46:28 UTC

Jarda is not owner of FEQ. At most core team is owner of project/queries, but I no longer work in core exclusively.

Anyway Andrei managed to fix issue 147492 and as such there are no longer any DataObjects not using own lookup. I 
guess this issue can be marked as fixed.

Comment 9 Tomas Zezula 2008-09-24 12:51:19 UTC

Right, Andrei's patch fixes this issue.