This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 92927

Summary:	Move AttributesUtilities to editor/settings API
Product:	editor	Reporter:	Vitezslav Stejskal <vstejskal>
Component:	Settings	Assignee:	apireviews <apireviews>
Status:	RESOLVED FIXED
Severity:	blocker	Keywords:	API, API_REVIEW_FAST
Priority:	P3
Version:	6.x
Hardware:	All
OS:	All
Issue Type:	TASK	Exception Reporter:
Attachments:	Javadoc of AttributesUtilities

Description Vitezslav Stejskal 2007-01-22 02:25:11 UTC

The AttributesUtilities class provides several static methods that simplify work
with javax.swing.AttributeSet. It's been introduced in the new Highlighting SPI,
but there are other parts of the system (unrelated to highlighting layers) that
could benefit from this class as well. Generally speaking, it might be usefull
for any code using FontColorSettings from the editor/settings API. This for
example includes editor/settings/storage and editor/options modules, the
Highlighting SPI itself and all the highlighting layer implementations, etc.

We would like to move the AttributesUtilities class from Highlighting SPI
(editor/lib2) to Editor Settings API (editor/settings). The class has only been
introduced recently in trunk builds and there are no modules outside of netbeans
using it, so there should be no compatiibility problems. We will update all
existing netbeans modules impacted by the change.

Comment 1 Vitezslav Stejskal 2007-01-22 02:28:55 UTC

Created attachment 37555 [details]
Javadoc of AttributesUtilities

Comment 2 Vitezslav Stejskal 2007-01-22 02:31:57 UTC

May I ask for a fast track review of this change, please? Thank you.

Comment 3 Vitezslav Stejskal 2007-01-26 05:02:34 UTC

Done.

Checking in lib2/nbproject/project.properties;
/cvs/editor/lib2/nbproject/project.properties,v  <--  project.properties
new revision: 1.3; previous revision: 1.2
done
Checking in lib2/nbproject/project.xml;
/cvs/editor/lib2/nbproject/project.xml,v  <--  project.xml
new revision: 1.3; previous revision: 1.2
done
Checking in settings/storage/nbproject/project.xml;
/cvs/editor/settings/storage/nbproject/project.xml,v  <--  project.xml
new revision: 1.10; previous revision: 1.9
done
Checking in
lib2/src/org/netbeans/modules/editor/lib2/highlighting/TextSelectionHighlighting.java;
/cvs/editor/lib2/src/org/netbeans/modules/editor/lib2/highlighting/TextSelectionHighlighting.java,v
 <--  TextSelectionHighlighting.java
new revision: 1.3; previous revision: 1.2
done
Checking in
lib2/src/org/netbeans/modules/editor/lib2/highlighting/CaretRowHighlighting.java;
/cvs/editor/lib2/src/org/netbeans/modules/editor/lib2/highlighting/CaretRowHighlighting.java,v
 <--  CaretRowHighlighting.java
new revision: 1.3; previous revision: 1.2
done
Checking in
lib2/src/org/netbeans/modules/editor/lib2/highlighting/ProxyHighlightsContainer.java;
/cvs/editor/lib2/src/org/netbeans/modules/editor/lib2/highlighting/ProxyHighlightsContainer.java,v
 <--  ProxyHighlightsContainer.java
new revision: 1.3; previous revision: 1.2
done
Checking in
lib2/src/org/netbeans/modules/editor/lib2/highlighting/SyntaxHighlighting.java;
/cvs/editor/lib2/src/org/netbeans/modules/editor/lib2/highlighting/SyntaxHighlighting.java,v
 <--  SyntaxHighlighting.java
new revision: 1.6; previous revision: 1.5
done
Checking in
lib2/test/unit/src/org/netbeans/modules/editor/lib2/highlighting/ProxyHighlightsContainerTest.java;
/cvs/editor/lib2/test/unit/src/org/netbeans/modules/editor/lib2/highlighting/ProxyHighlightsContainerTest.java,v
 <--  ProxyHighlightsContainerTest.java
new revision: 1.3; previous revision: 1.2
done
Checking in
lib2/test/unit/src/org/netbeans/modules/editor/lib2/highlighting/CompoundHighlightsContainerTest.java;
/cvs/editor/lib2/test/unit/src/org/netbeans/modules/editor/lib2/highlighting/CompoundHighlightsContainerTest.java,v
 <--  CompoundHighlightsContainerTest.java
new revision: 1.3; previous revision: 1.2
done
Checking in
lib/bridge/src/org/netbeans/modules/editor/oldlibbridge/GuardedBlocksHighlighting.java;
/cvs/editor/lib/bridge/src/org/netbeans/modules/editor/oldlibbridge/GuardedBlocksHighlighting.java,v
 <--  GuardedBlocksHighlighting.java
new revision: 1.3; previous revision: 1.2
done
Checking in
lib/bridge/src/org/netbeans/modules/editor/oldlibbridge/HighlightingDrawLayer.java;
/cvs/editor/lib/bridge/src/org/netbeans/modules/editor/oldlibbridge/HighlightingDrawLayer.java,v
 <--  HighlightingDrawLayer.java
new revision: 1.8; previous revision: 1.7
done
Checking in
settings/storage/src/org/netbeans/modules/editor/settings/storage/ColoringStorage.java;
/cvs/editor/settings/storage/src/org/netbeans/modules/editor/settings/storage/ColoringStorage.java,v
 <--  ColoringStorage.java
new revision: 1.25; previous revision: 1.24
done
Checking in
settings/storage/src/org/netbeans/modules/editor/settings/storage/Utils.java;
/cvs/editor/settings/storage/src/org/netbeans/modules/editor/settings/storage/Utils.java,v
 <--  Utils.java
new revision: 1.17; previous revision: 1.16
done
Removing
settings/storage/src/org/netbeans/modules/editor/settings/storage/AttributesUtilities.java;
/cvs/editor/settings/storage/src/org/netbeans/modules/editor/settings/storage/AttributesUtilities.java,v
 <--  AttributesUtilities.java
new revision: delete; previous revision: 1.3
done
Checking in
settings/storage/src/org/netbeans/modules/editor/settings/storage/CompositeFCS.java;
/cvs/editor/settings/storage/src/org/netbeans/modules/editor/settings/storage/CompositeFCS.java,v
 <--  CompositeFCS.java
new revision: 1.3; previous revision: 1.2
done
Checking in lib/bridge/nbproject/project.xml;
/cvs/editor/lib/bridge/nbproject/project.xml,v  <--  project.xml
new revision: 1.3; previous revision: 1.2
done
Checking in settings/manifest.mf;
/cvs/editor/settings/manifest.mf,v  <--  manifest.mf
new revision: 1.9; previous revision: 1.8
done
RCS file:
/cvs/editor/settings/test/unit/src/org/netbeans/api/editor/settings/AttributesUtilitiesTest.java,v
done
Checking in
settings/test/unit/src/org/netbeans/api/editor/settings/AttributesUtilitiesTest.java;
/cvs/editor/settings/test/unit/src/org/netbeans/api/editor/settings/AttributesUtilitiesTest.java,v
 <--  AttributesUtilitiesTest.java
initial revision: 1.1
done
Checking in lib2/src/org/netbeans/spi/editor/highlighting/support/OffsetsBag.java;
/cvs/editor/lib2/src/org/netbeans/spi/editor/highlighting/support/OffsetsBag.java,v
 <--  OffsetsBag.java
new revision: 1.3; previous revision: 1.2
done
Checking in lib2/src/org/netbeans/spi/editor/highlighting/support/PositionsBag.java;
/cvs/editor/lib2/src/org/netbeans/spi/editor/highlighting/support/PositionsBag.java,v
 <--  PositionsBag.java
new revision: 1.3; previous revision: 1.2
done
RCS file:
/cvs/editor/settings/src/org/netbeans/api/editor/settings/AttributesUtilities.java,v
done
Checking in settings/src/org/netbeans/api/editor/settings/AttributesUtilities.java;
/cvs/editor/settings/src/org/netbeans/api/editor/settings/AttributesUtilities.java,v
 <--  AttributesUtilities.java
initial revision: 1.1
done
Checking in settings/api/apichanges.xml;
/cvs/editor/settings/api/apichanges.xml,v  <--  apichanges.xml
new revision: 1.9; previous revision: 1.8
done
Checking in lib2/apichanges.xml;
/cvs/editor/lib2/apichanges.xml,v  <--  apichanges.xml
new revision: 1.3; previous revision: 1.2
done
Removing
lib2/test/unit/src/org/netbeans/spi/editor/highlighting/AttributesUtilitiesTest.java;
/cvs/editor/lib2/test/unit/src/org/netbeans/spi/editor/highlighting/AttributesUtilitiesTest.java,v
 <--  AttributesUtilitiesTest.java
new revision: delete; previous revision: 1.3
done
Removing lib2/src/org/netbeans/spi/editor/highlighting/AttributesUtilities.java;
/cvs/editor/lib2/src/org/netbeans/spi/editor/highlighting/AttributesUtilities.java,v
 <--  AttributesUtilities.java
new revision: delete; previous revision: 1.3
done
Checking in
lib2/test/unit/src/org/netbeans/spi/editor/highlighting/support/PositionsBagRandomTest.java;
/cvs/editor/lib2/test/unit/src/org/netbeans/spi/editor/highlighting/support/PositionsBagRandomTest.java,v
 <--  PositionsBagRandomTest.java
new revision: 1.3; previous revision: 1.2
done